Skip to content

Code Quality: Implemented Command Palette mode in Omnibar #17104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 20, 2025
Merged

Code Quality: Implemented Command Palette mode in Omnibar #17104

merged 12 commits into from
May 20, 2025

Conversation

@0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented May 7, 2025 •
edited
Loading

Resolved / Related Issues

Steps used to test these changes

  1. Open Files app
  2. Enable Omnibar from Settings > Advanced
  3. Test the Palette mode
    1. Filter the commands
    2. Click on a command

@0x5bfa 0x5bfa changed the title Code Quality: Introduced Omnia\bar 2 Code Quality: Introduced Omnibar 2 May 7, 2025
@yaira2 yaira2 changed the title Code Quality: Introduced Omnibar 2 Code Quality: Implemented Command Palette mode in Omnibar May 8, 2025
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-Omnibar2 branch from 5c09ad6 to 55b159e Compare May 13, 2025 03:12
@yaira2 yaira2 force-pushed the 5bfa/CQ-Omnibar2 branch from 55b159e to a3c54ed Compare May 13, 2025 14:16
yaira2
yaira2 reviewed May 14, 2025
View reviewed changes
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-Omnibar2 branch from abef1c4 to 47c3eab Compare May 15, 2025 15:11
yaira2
yaira2 reviewed May 19, 2025
View reviewed changes
yaira2
yaira2 reviewed May 19, 2025
View reviewed changes
yaira2
yaira2 reviewed May 19, 2025
View reviewed changes
@yaira2 yaira2 added the changes requested Changes are needed for this pull request label May 19, 2025
@yaira2 yaira2 marked this pull request as ready for review May 19, 2025 15:40
yaira2
yaira2 previously approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented May 20, 2025

@0x5bfa can you please resolve the merge conflict?

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels May 20, 2025
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-Omnibar2 branch from 6ebba96 to ec68157 Compare May 20, 2025 14:45
yaira2
yaira2 previously approved these changes May 20, 2025
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented May 20, 2025

/format

@files-community-bot
Copy link
Contributor

files-community-bot bot commented May 20, 2025

✅ Successfully formatted XAML files.

@yaira2 yaira2 merged commit df84e67 into files-community:main May 20, 2025
@0x5bfa 0x5bfa deleted the 5bfa/CQ-Omnibar2 branch May 20, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 left review comments

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x5bfa @yaira2