From 0d646a23a040aba3267574743d565277dda22977 Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Mon, 26 May 2025 19:45:56 +0100 Subject: [PATCH 1/3] Show all extensions that can be used as a folder icon --- src/Files.App/Strings/en-US/Resources.resw | 4 ++++ src/Files.App/ViewModels/Properties/CustomizationViewModel.cs | 1 + 2 files changed, 5 insertions(+) diff --git a/src/Files.App/Strings/en-US/Resources.resw b/src/Files.App/Strings/en-US/Resources.resw index ccad5674699c..7bb6bf4da6c2 100644 --- a/src/Files.App/Strings/en-US/Resources.resw +++ b/src/Files.App/Strings/en-US/Resources.resw @@ -4236,4 +4236,8 @@ Status center progress ping Screen reader name for the status center progress ring + + Icon files + This is the friendly name for a variety of different icon files. + diff --git a/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs b/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs index 55d926c25698..0e74f6604a07 100644 --- a/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs +++ b/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs @@ -95,6 +95,7 @@ private void ExecuteOpenFilePickerCommand() string[] extensions = [ + Strings.IconFile.GetLocalizedResource(), "*.dll; *.exe; *.ico; *.icl", Strings.ApplicationExtension.GetLocalizedResource(), "*.dll", Strings.Application.GetLocalizedResource(), "*.exe", Strings.IcoFileCapitalized.GetLocalizedResource(), "*.ico", From 367d2bb9f6fe090e0a971e96ce6aeeea8f323206 Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Tue, 27 May 2025 08:22:03 +0100 Subject: [PATCH 2/3] Rename the "IconFile" resource string name to "IconFiles" --- src/Files.App/Strings/en-US/Resources.resw | 2 +- src/Files.App/ViewModels/Properties/CustomizationViewModel.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Files.App/Strings/en-US/Resources.resw b/src/Files.App/Strings/en-US/Resources.resw index 7bb6bf4da6c2..31013adb5b84 100644 --- a/src/Files.App/Strings/en-US/Resources.resw +++ b/src/Files.App/Strings/en-US/Resources.resw @@ -4236,7 +4236,7 @@ Status center progress ping Screen reader name for the status center progress ring - + Icon files This is the friendly name for a variety of different icon files. diff --git a/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs b/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs index 0e74f6604a07..95fda6927bf5 100644 --- a/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs +++ b/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs @@ -95,7 +95,7 @@ private void ExecuteOpenFilePickerCommand() string[] extensions = [ - Strings.IconFile.GetLocalizedResource(), "*.dll; *.exe; *.ico; *.icl", + Strings.IconFiles.GetLocalizedResource(), "*.dll; *.exe; *.ico; *.icl", Strings.ApplicationExtension.GetLocalizedResource(), "*.dll", Strings.Application.GetLocalizedResource(), "*.exe", Strings.IcoFileCapitalized.GetLocalizedResource(), "*.ico", From 19f5cf67fb98e41af1967eb41e3299c2eef638bb Mon Sep 17 00:00:00 2001 From: Lamparter <71598437+Lamparter@users.noreply.github.com> Date: Tue, 27 May 2025 08:26:47 +0100 Subject: [PATCH 3/3] Match extension pattern to that of the Windows shell --- src/Files.App/ViewModels/Properties/CustomizationViewModel.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs b/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs index 95fda6927bf5..b6869ec059a5 100644 --- a/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs +++ b/src/Files.App/ViewModels/Properties/CustomizationViewModel.cs @@ -95,7 +95,7 @@ private void ExecuteOpenFilePickerCommand() string[] extensions = [ - Strings.IconFiles.GetLocalizedResource(), "*.dll; *.exe; *.ico; *.icl", + Strings.IconFiles.GetLocalizedResource(), "*.dll;*.exe;*.ico;*.icl", Strings.ApplicationExtension.GetLocalizedResource(), "*.dll", Strings.Application.GetLocalizedResource(), "*.exe", Strings.IcoFileCapitalized.GetLocalizedResource(), "*.ico",