Skip to content

Feature: Added option to browse all icon files in file picker #17158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Feature: Added option to browse all icon files in file picker #17158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d646a2
Show all extensions that can be used as a folder icon
Lamparter May 26, 2025
367d2bb
Rename the "IconFile" resource string name to "IconFiles"
Lamparter May 27, 2025
19f5cf6
Match extension pattern to that of the Windows shell
Lamparter May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Files.App/Strings/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4236,4 +4236,8 @@
<value>Status center progress ping</value>
<comment>Screen reader name for the status center progress ring</comment>
</data>
<data name="IconFiles" xml:space="preserve">
<value>Icon files</value>
<comment>This is the friendly name for a variety of different icon files.</comment>
</data>
</root>
1 change: 1 addition & 0 deletions src/Files.App/ViewModels/Properties/CustomizationViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ private void ExecuteOpenFilePickerCommand()

string[] extensions =
[
Strings.IconFiles.GetLocalizedResource(), "*.dll;*.exe;*.ico;*.icl",
Strings.ApplicationExtension.GetLocalizedResource(), "*.dll",
Strings.Application.GetLocalizedResource(), "*.exe",
Strings.IcoFileCapitalized.GetLocalizedResource(), "*.ico",
Expand Down
Loading