Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Verified that the application no longer crashes when accessing Windows libraries with restricted permissions.
  2. Checked the logs for warning messages indicating access denied to specific library folders.
  3. Ensured that the application continues to function correctly when accessing libraries with full permissions.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 marked this pull request as ready for review July 31, 2025 01:08
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Jul 31, 2025
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails because there is no using Microsoft.Extensions.Logging;.
That being said, I would like to propose another fix.

@yaira2 yaira2 closed this Jul 31, 2025
@yaira2 yaira2 deleted the seer/fix/unauthorized-library-access branch July 31, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants