Skip to content

Fix: Handle UnauthorizedAccessException when accessing library folders #17374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix: Handle UnauthorizedAccessException when accessing library folders #17374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/Files.App/Utils/Shell/ShellFolderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,18 @@
IsPinned = library.PinnedToNavigationPane,
};

var folders = library.Folders;
if (folders.Count > 0)
try
{
libraryItem.DefaultSaveFolder = SafetyExtensions.IgnoreExceptions(() => library.DefaultSaveFolder.FileSystemPath);
libraryItem.Folders = folders.Select(f => f.FileSystemPath).ToArray();
var folders = library.Folders;
if (folders.Count > 0)
{
libraryItem.DefaultSaveFolder = SafetyExtensions.IgnoreExceptions(() => library.DefaultSaveFolder.FileSystemPath);
libraryItem.Folders = folders.Select(f => f.FileSystemPath).ToArray();
}
}
catch (UnauthorizedAccessException ex)
{
App.Logger.LogWarning(ex, $"Access denied to library folders for {filePath}");

Check failure on line 37 in src/Files.App/Utils/Shell/ShellFolderExtensions.cs

View workflow job for this annotation

GitHub Actions / build (Debug, x64) 

'ILogger' does not contain a definition for 'LogWarning' and no accessible extension method 'LogWarning' accepting a first argument of type 'ILogger' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 37 in src/Files.App/Utils/Shell/ShellFolderExtensions.cs

View workflow job for this annotation

GitHub Actions / build (Release, x64) 

'ILogger' does not contain a definition for 'LogWarning' and no accessible extension method 'LogWarning' accepting a first argument of type 'ILogger' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 37 in src/Files.App/Utils/Shell/ShellFolderExtensions.cs

View workflow job for this annotation

GitHub Actions / build (Debug, arm64) 

'ILogger' does not contain a definition for 'LogWarning' and no accessible extension method 'LogWarning' accepting a first argument of type 'ILogger' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 37 in src/Files.App/Utils/Shell/ShellFolderExtensions.cs

View workflow job for this annotation

GitHub Actions / build (Release, arm64) 

'ILogger' does not contain a definition for 'LogWarning' and no accessible extension method 'LogWarning' accepting a first argument of type 'ILogger' could be found (are you missing a using directive or an assembly reference?)
}

return libraryItem;
Expand Down
Loading