Feature: Auto size columns #17407
Merged
Feature: Auto size columns #17407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements auto-sizing functionality for columns in the ColumnShell view, allowing columns to automatically adjust their width based on content.
- Adds automatic column width sizing when items finish loading
- Introduces proper event handling for cleanup in ColumnShellPage
- Reduces default column width from 300 to 200 pixels
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ColumnShellPage.xaml.cs | Adds event cleanup in Page_Unloaded method |
| ColumnShellPage.xaml | Wires up Unloaded event handler |
| ColumnsLayoutPage.xaml.cs | Adds SetWidth method to trigger auto-sizing |
| ColumnsLayoutPage.xaml | Reduces default column width from 300 to 200 |
| ColumnLayoutPage.xaml.cs | Implements auto-sizing logic when items load |
| BladeView.xaml | Removes transitions and min width constraints |
| BladeItem.cs | Refactors width calculation and reduces default width |
Comments suppressed due to low confidence (1)
Co-authored-by: Copilot <[email protected]> Signed-off-by: Yair <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Yair <[email protected]>
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.