Code Quality: Fixed Omnibar issues #17408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaira2
requested review from
0x5bfa and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the Omnibar AutoSuggestBox would regain focus and show suggestions popup when the window was refocused. The fix adds a workaround to restore focus to the previously focused element when the AutoSuggestBox loses focus due to the specific scenario of window focus changes.
Key Changes
- Added logic to restore focus to the previously focused element when AutoSuggestBox loses focus in specific conditions
- Included detailed comment explaining the workaround for window refocus behavior
yaira2
changed the title
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.'Search' action doesn't work when triggered from the Command PaletteSwitching to a different window while the flyout is open closes it, but it reopens when refocusing the windowSteps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.