Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. The issue was that: INI parser's List.IndexOf on duplicate sections yields negative range length for List.GetRange, causing ArgumentOutOfRangeException.
  2. Fixed issue where WindowsIniService was not handling duplicate section names correctly.
  3. Changed the way section line indexes are retrieved to handle duplicate section names.
  4. Added a check to ensure that the count of lines in a section is greater than 0.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 740205

Not quite right? Click here to continue debugging with Seer.

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Aug 11, 2025
@yaira2 yaira2 marked this pull request as ready for review August 11, 2025 03:38
@yaira2 yaira2 self-requested a review August 11, 2025 03:38
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit c6654f4 into main Aug 11, 2025
7 checks passed
@yaira2 yaira2 deleted the seer/fix/windows-ini-service-duplicate-sections branch August 11, 2025 23:01
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants