Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Observed that StorageProviderSyncRootInfo.Id being null, unhandled, causes NullReferenceException during registry path string interpolation.
  2. Verified that the added null check for syncRootInfo.Id in SyncRootHelpers.cs prevents a crash when sync root info is null.
  3. Confirmed that the try-catch block in DriveProperties.cs handles exceptions when getting sync root quota.
  4. Verified fix generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 740216. Click here to continue debugging with Seer.

@yaira2 yaira2 marked this pull request as ready for review August 11, 2025 03:38
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Aug 11, 2025
@yaira2 yaira2 self-requested a review August 11, 2025 03:38
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Aug 11, 2025
@yaira2 yaira2 merged commit 70970b7 into main Aug 11, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/fix-sync-root-null-crash branch August 11, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants