Skip to content

Fix: Prevent crash when sync root info is null #17430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

Fix: Prevent crash when sync root info is null #17430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Files.App/Utils/Storage/Helpers/SyncRootHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ private static unsafe (bool Success, ulong Capacity, ulong Used) GetSyncRootQuot
return (false, 0, 0);
}

if (syncRootInfo is null)
if (syncRootInfo is null || syncRootInfo.Id is null)
{
return (false, 0, 0);
}
Expand Down
19 changes: 13 additions & 6 deletions src/Files.App/ViewModels/Properties/Items/DriveProperties.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,20 @@ public async override Task GetSpecialPropertiesAsync()
return;
}

var syncRootStatus = await SyncRootHelpers.GetSyncRootQuotaAsync(Drive.Path);
if (syncRootStatus.Success)
try
{
ViewModel.DriveCapacityValue = syncRootStatus.Capacity;
ViewModel.DriveUsedSpaceValue = syncRootStatus.Used;
ViewModel.DriveFreeSpaceValue = syncRootStatus.Capacity - syncRootStatus.Used;
return;
var syncRootStatus = await SyncRootHelpers.GetSyncRootQuotaAsync(Drive.Path);
if (syncRootStatus.Success)
{
ViewModel.DriveCapacityValue = syncRootStatus.Capacity;
ViewModel.DriveUsedSpaceValue = syncRootStatus.Used;
ViewModel.DriveFreeSpaceValue = syncRootStatus.Capacity - syncRootStatus.Used;
return;
}
}
catch (Exception e)
{
App.Logger.LogWarning(e, "Failed to get sync root quota for path: {Path}", Drive.Path);
}

try
Expand Down
Loading