Skip to content

Fix: Added conditional checking for virtual network path #17664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2025
Merged

Fix: Added conditional checking for virtual network path #17664

merged 2 commits into from
Sep 28, 2025
+15 −0

Conversation

@NicholasChin28
Copy link
Contributor

@NicholasChin28 NicholasChin28 commented Sep 20, 2025 •
edited
Loading

Resolved / Related Issues

Steps used to test these changes

  1. Download and install RaiDrive client application
  2. Configure RaiDrive to mount an SFTP server connection via the RaiDrive GUI client
  3. Verify the SFTP drive appears in Windows File Explorer as a network location
image
  1. Attempt to access the RaiDrive SFTP drive using the Files application
  2. Upon step debugging through AuthenticateNetworkShare function, observe that
    RaiDrive SFTP paths follow the format \RaiDrive-{username}{drive-custom-name}\
image image
  1. Notice that WNetAddConnection3W fails when attempting to resolve the RaiDrive
    remoteName with either ERROR_BAD_NET_NAME or ERROR_NO_NET_OR_BAD_PATH
image

  1. After applying the fix, successfully access RaiDrive SFTP drives through Files
    application without errors

  2. Checked with SSHFS to test behavior.

image image image
  1. SSHFS connecting to a SFTP server seems fine as it does prompt user to key in credentials and after inputting details the folder is accessible.

@NicholasChin28
Added conditional checking for RaiDrive drive path
31890bc 
- RaiDrive seems to use a custom UNC path with the format of \\RaiDrive-{user}\{drive-custom-name}
@NicholasChin28 NicholasChin28 mentioned this pull request Sep 20, 2025
Closed
@yaira2 yaira2 changed the title Added conditional checking for RaiDrive network path Fix: Added conditional checking for RaiDrive network path Sep 21, 2025
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Sep 21, 2025
yaira2
yaira2 reviewed Sep 21, 2025
View reviewed changes
@Josh65-2201
Copy link
Member

Josh65-2201 commented Sep 25, 2025 •
edited
Loading

Could this also apply to #17636 based on the site it's a separate program that adds a virtual network drive too

@NicholasChin28
Updated conditional checking for virtual disk providers
f1efa0a 
- Added constant array of virtual disk providers
@NicholasChin28 NicholasChin28 changed the title Fix: Added conditional checking for RaiDrive network path Fix: Added conditional checking for virtual network path Sep 27, 2025
@NicholasChin28
Copy link
Contributor Author

NicholasChin28 commented Sep 27, 2025 •
edited
Loading

I had a look at #17636 and it seems to have a similar issue. When testing:

  • The lock/authenticated status of the virtual drive is controlled from the Cryptomator desktop app
  • In the Windows File Explorer, once the drive has been unlocked, it immediately allows access without prompting for login credentials
  • I assume this is because its already unlocked so it should not prompt/require the user to re-enter the details

Another potentially related issue is #17521

  • For this one, it has a similar behavior to RaiDrive in the original comment

@NicholasChin28
Copy link
Contributor Author

NicholasChin28 commented Sep 27, 2025

I have updated the code to maintain a list of providers that seems to be using a virtual network drive. I'm not sure if we want to include the checks for both Cryptomator and Egnyte in this PR.

@yaira2
Copy link
Member

yaira2 commented Sep 28, 2025

I have updated the code to maintain a list of providers that seems to be using a virtual network drive. I'm not sure if we want to include the checks for both Cryptomator and Egnyte in this PR.

I think it's fine to include them in the same PR.

yaira2
yaira2 approved these changes Sep 28, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Sep 28, 2025
@yaira2 yaira2 merged commit 8aa4fb7 into files-community:main Sep 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Opening network drive from RaiDrive shows ERROR_BAD_NET_NAME

3 participants

@NicholasChin28 @Josh65-2201 @yaira2