chore: enable nullable

Author: filzrev

src/BenchmarkDotNet.Annotations/Attributes/ParamsAttribute.cs

@@ -1,5 +1,7 @@
 using System;
 
+#nullable enable
+
 namespace BenchmarkDotNet.Attributes
 {
     [AttributeUsage(AttributeTargets.Field | AttributeTargets.Property)]
@@ -8,9 +10,9 @@ public class ParamsAttribute : PriorityAttribute
         public object?[] Values { get; protected set; }
 
         // CLS-Compliant Code requires a constructor without an array in the argument list
-        public ParamsAttribute() => Values = new object[0];
+        public ParamsAttribute() => Values = [];
 
         public ParamsAttribute(params object?[]? values)
-            => Values = values ?? new object?[] { null }; // when users do Params(null) they mean one, null argument
+            => Values = values ?? [null]; // when users do Params(null) they mean one, null argument
     }
 }

src/BenchmarkDotNet.TestAdapter/VSTestEventProcessor.cs

@@ -15,6 +15,8 @@
 using System.Text;
 using System.Threading;
 
+#nullable enable
+
 namespace BenchmarkDotNet.TestAdapter
 {
     /// <summary>
@@ -81,7 +83,7 @@ public override void OnBuildComplete(BuildPartition buildPartition, BuildResult
 
                     if (buildResult.GenerateException != null)
                         testResult.ErrorMessage = $"// Generate Exception: {buildResult.GenerateException.Message}";
-                    else if (!buildResult.IsBuildSuccess && buildResult.TryToExplainFailureReason(out string reason))
+                    else if (!buildResult.IsBuildSuccess && buildResult.TryToExplainFailureReason(out string? reason))
                         testResult.ErrorMessage = $"// Build Error: {reason}";
                     else if (buildResult.ErrorMessage != null)
                         testResult.ErrorMessage = $"// Build Error: {buildResult.ErrorMessage}";

src/BenchmarkDotNet/Columns/LogicalGroupColumn.cs

@@ -2,6 +2,8 @@
 using BenchmarkDotNet.Running;
 using JetBrains.Annotations;
 
+#nullable enable
+
 namespace BenchmarkDotNet.Columns
 {
     public class LogicalGroupColumn : IColumn
@@ -11,7 +13,7 @@ public class LogicalGroupColumn : IColumn
         public string Id => nameof(LogicalGroupColumn);
         public string ColumnName => Column.LogicalGroup;
 
-        public string GetValue(Summary summary, BenchmarkCase benchmarkCase) => summary.GetLogicalGroupKey(benchmarkCase);
+        public string GetValue(Summary summary, BenchmarkCase benchmarkCase) => summary.GetLogicalGroupKey(benchmarkCase) ?? "";
         public string GetValue(Summary summary, BenchmarkCase benchmarkCase, SummaryStyle style) => GetValue(summary, benchmarkCase);
         public bool IsDefault(Summary summary, BenchmarkCase benchmarkCase) => false;
         public bool IsAvailable(Summary summary) => true;

src/BenchmarkDotNet/Detectors/Cpu/HardwareIntrinsics.cs

@@ -9,6 +9,8 @@
 using System.Runtime.Intrinsics.Arm;
 #endif
 
+#nullable enable
+
 namespace BenchmarkDotNet.Detectors.Cpu
 {
     // based on https://github.com/dotnet/runtime/tree/v10.0.0-rc.1.25451.107/src/coreclr/tools/Common/JitInterface/ThunkGenerator/InstructionSetDesc.txt
@@ -281,10 +283,10 @@ static IEnumerable<string> GetCurrentProcessInstructionSets(Platform platform)
 
         private static bool GetIsSupported([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] string typeName)
         {
-            Type type = Type.GetType(typeName);
+            Type type = Type.GetType(typeName)!;
             if (type == null) return false;
 
-            return (bool)type.GetProperty("IsSupported", System.Reflection.BindingFlags.Public | System.Reflection.BindingFlags.Static).GetValue(null, null);
+            return (bool)type.GetProperty("IsSupported", System.Reflection.BindingFlags.Public | System.Reflection.BindingFlags.Static)!.GetValue(null, null)!;
         }
     }
 }

src/BenchmarkDotNet/Detectors/Cpu/Linux/LinuxCpuInfoParser.cs

@@ -10,6 +10,8 @@
 
 namespace BenchmarkDotNet.Detectors.Cpu.Linux;
 
+#nullable enable
+
 internal static class LinuxCpuInfoParser
 {
     private static class ProcCpu
@@ -42,27 +44,27 @@ internal static CpuInfo Parse(string cpuInfo, string lscpu)
         var logicalCores = SectionsHelper.ParseSections(cpuInfo, ':');
         foreach (var logicalCore in logicalCores)
         {
-            if (logicalCore.TryGetValue(ProcCpu.PhysicalId, out string physicalId) &&
-                logicalCore.TryGetValue(ProcCpu.CpuCores, out string cpuCoresValue) &&
+            if (logicalCore.TryGetValue(ProcCpu.PhysicalId, out var physicalId) &&
+                logicalCore.TryGetValue(ProcCpu.CpuCores, out var cpuCoresValue) &&
                 int.TryParse(cpuCoresValue, out int cpuCoreCount) &&
                 cpuCoreCount > 0)
                 processorsToPhysicalCoreCount[physicalId] = cpuCoreCount;
 
-            if (logicalCore.TryGetValue(ProcCpu.ModelName, out string modelName))
+            if (logicalCore.TryGetValue(ProcCpu.ModelName, out var modelName))
             {
                 processorModelNames.Add(modelName);
                 logicalCoreCount++;
             }
 
-            if (logicalCore.TryGetValue(ProcCpu.MaxFrequency, out string maxCpuFreqValue) &&
+            if (logicalCore.TryGetValue(ProcCpu.MaxFrequency, out var maxCpuFreqValue) &&
                 Frequency.TryParseMHz(maxCpuFreqValue.Replace(',', '.'), out Frequency maxCpuFreq)
                 && maxCpuFreq > 0)
             {
                 maxFrequency = Math.Max(maxFrequency, maxCpuFreq.ToMHz());
             }
 
-            bool nominalFrequencyHasValue = logicalCore.TryGetValue(ProcCpu.NominalFrequency, out string nominalFreqValue);
-            bool nominalFrequencyBackupHasValue = logicalCore.TryGetValue(ProcCpu.NominalFrequencyBackup, out string nominalFreqBackupValue);
+            bool nominalFrequencyHasValue = logicalCore.TryGetValue(ProcCpu.NominalFrequency, out var nominalFreqValue);
+            bool nominalFrequencyBackupHasValue = logicalCore.TryGetValue(ProcCpu.NominalFrequencyBackup, out var nominalFreqBackupValue);
 
             double nominalCpuFreq = 0.0;
             double nominalCpuBackupFreq = 0.0;
@@ -115,7 +117,7 @@ internal static CpuInfo Parse(string cpuInfo, string lscpu)
             }
         }
 
-        string processorName = processorModelNames.Count > 0 ? string.Join(", ", processorModelNames) : null;
+        string? processorName = processorModelNames.Count > 0 ? string.Join(", ", processorModelNames) : null;
         int? physicalProcessorCount = processorsToPhysicalCoreCount.Count > 0 ? processorsToPhysicalCoreCount.Count : null;
         int? physicalCoreCount = processorsToPhysicalCoreCount.Count > 0 ? processorsToPhysicalCoreCount.Values.Sum() : coresPerSocket;
 

src/BenchmarkDotNet/Detectors/Cpu/Windows/MosCpuDetector.cs

@@ -8,6 +8,8 @@
 using Perfolizer.Horology;
 using Perfolizer.Models;
 
+#nullable enable
+
 namespace BenchmarkDotNet.Detectors.Cpu.Windows;
 
 internal class MosCpuDetector : ICpuDetector
@@ -33,7 +35,7 @@ public bool IsApplicable() => OsDetector.IsWindows() &&
         {
             foreach (var moProcessor in mosProcessor.Get().Cast<ManagementObject>())
             {
-                string name = moProcessor[WmicCpuInfoKeyNames.Name]?.ToString();
+                string? name = moProcessor[WmicCpuInfoKeyNames.Name]?.ToString();
                 if (name.IsNotBlank())
                 {
                     processorModelNames.Add(name);
@@ -51,7 +53,7 @@ public bool IsApplicable() => OsDetector.IsWindows() &&
             }
         }
 
-        string processorName = processorModelNames.Count > 0 ? string.Join(", ", processorModelNames) : null;
+        string? processorName = processorModelNames.Count > 0 ? string.Join(", ", processorModelNames) : null;
         Frequency? maxFrequencyActual = maxFrequency > 0 && processorsCount > 0
             ? Frequency.FromMHz(maxFrequency)
             : null;

src/BenchmarkDotNet/Detectors/Cpu/Windows/PowershellWmiCpuInfoParser.cs

@@ -7,6 +7,8 @@
 
 namespace BenchmarkDotNet.Detectors.Cpu.Windows;
 
+#nullable enable
+
 internal static class PowershellWmiCpuInfoParser
 {
     internal static CpuInfo Parse(string powershellWmiOutput)
@@ -22,23 +24,23 @@ internal static CpuInfo Parse(string powershellWmiOutput)
         List<Dictionary<string, string>> processors = SectionsHelper.ParseSectionsForPowershellWmi(powershellWmiOutput, ':');
         foreach (Dictionary<string, string> processor in processors)
         {
-            if (processor.TryGetValue(WmicCpuInfoKeyNames.NumberOfCores, out string numberOfCoresValue) &&
+            if (processor.TryGetValue(WmicCpuInfoKeyNames.NumberOfCores, out string? numberOfCoresValue) &&
                 int.TryParse(numberOfCoresValue, out int numberOfCores) &&
                 numberOfCores > 0)
                 physicalCoreCount += numberOfCores;
 
-            if (processor.TryGetValue(WmicCpuInfoKeyNames.NumberOfLogicalProcessors, out string numberOfLogicalValue) &&
+            if (processor.TryGetValue(WmicCpuInfoKeyNames.NumberOfLogicalProcessors, out string? numberOfLogicalValue) &&
                 int.TryParse(numberOfLogicalValue, out int numberOfLogical) &&
                 numberOfLogical > 0)
                 logicalCoreCount += numberOfLogical;
 
-            if (processor.TryGetValue(WmicCpuInfoKeyNames.Name, out string name))
+            if (processor.TryGetValue(WmicCpuInfoKeyNames.Name, out string? name))
             {
                 processorModelNames.Add(name);
                 processorCount++;
             }
 
-            if (processor.TryGetValue(WmicCpuInfoKeyNames.MaxClockSpeed, out string frequencyValue)
+            if (processor.TryGetValue(WmicCpuInfoKeyNames.MaxClockSpeed, out string? frequencyValue)
                 && double.TryParse(frequencyValue, out double frequency)
                 && frequency > 0)
             {

src/BenchmarkDotNet/Detectors/OsDetector.cs

@@ -10,6 +10,8 @@
 using RuntimeEnvironment = Microsoft.DotNet.PlatformAbstractions.RuntimeEnvironment;
 using System.Runtime.Versioning;
 
+#nullable enable
+
 namespace BenchmarkDotNet.Detectors;
 
 public class OsDetector
@@ -41,7 +43,7 @@ private static OsInfo ResolveOs()
         {
             try
             {
-                string version = LinuxOsReleaseHelper.GetNameByOsRelease(File.ReadAllLines("/etc/os-release"));
+                string? version = LinuxOsReleaseHelper.GetNameByOsRelease(File.ReadAllLines("/etc/os-release"));
                 bool wsl = IsUnderWsl();
                 return new OsInfo
                 {

src/BenchmarkDotNet/Diagnosers/DiagnosersLoader.cs

@@ -9,6 +9,8 @@
 using BenchmarkDotNet.Loggers;
 using BenchmarkDotNet.Portability;
 
+#nullable enable
+
 namespace BenchmarkDotNet.Diagnosers
 {
     internal static class DiagnosersLoader
@@ -95,6 +97,6 @@ private static IDiagnoser[] LoadWindowsDiagnosers()
         }
 
         private static IDiagnoser CreateDiagnoser(Assembly loadedAssembly, string typeName)
-            => (IDiagnoser)Activator.CreateInstance(loadedAssembly.GetType(typeName));
+            => (IDiagnoser)Activator.CreateInstance(loadedAssembly.GetType(typeName)!)!;
     }
 }

src/BenchmarkDotNet/Diagnosers/EventPipeProfiler.cs

@@ -18,6 +18,8 @@
 using BenchmarkDotNet.Validators;
 using Microsoft.Diagnostics.NETCore.Client;
 
+#nullable enable
+
 namespace BenchmarkDotNet.Diagnosers
 {
     public class EventPipeProfiler : IProfiler
@@ -28,11 +30,11 @@ public class EventPipeProfiler : IProfiler
         private readonly ImmutableHashSet<EventPipeProvider> eventPipeProviders;
         private readonly bool performExtraBenchmarksRun;
 
-        private Task collectingTask;
+        private Task collectingTask = default!;
 
         // parameterless constructor required by DiagnosersLoader to support creating this profiler via console line args
         // we use performExtraBenchmarksRun = false for better first user experience
-        public EventPipeProfiler() :this(profile: EventPipeProfile.CpuSampling, performExtraBenchmarksRun: false) { }
+        public EventPipeProfiler() : this(profile: EventPipeProfile.CpuSampling, performExtraBenchmarksRun: false) { }
 
         /// <summary>
         /// Creates a new instance of EventPipeProfiler
@@ -60,7 +62,7 @@ public IEnumerable<ValidationError> Validate(ValidationParameters validationPara
         {
             foreach (var benchmark in validationParameters.Benchmarks)
             {
-                var runtime = benchmark.Job.ResolveValue(EnvironmentMode.RuntimeCharacteristic, EnvironmentResolver.Instance);
+                var runtime = benchmark.Job.ResolveValue(EnvironmentMode.RuntimeCharacteristic, EnvironmentResolver.Instance)!;
 
                 if (runtime.RuntimeMoniker < RuntimeMoniker.NetCoreApp30)
                 {
@@ -127,7 +129,7 @@ public void DisplayResults(ILogger resultLogger)
             resultLogger.WriteLineInfo(benchmarkToTraceFile.Values.First());
         }
 
-        internal static ImmutableHashSet<EventPipeProvider> MapToProviders(EventPipeProfile profile, IReadOnlyCollection<EventPipeProvider> providers)
+        internal static ImmutableHashSet<EventPipeProvider> MapToProviders(EventPipeProfile profile, IReadOnlyCollection<EventPipeProvider>? providers)
         {
             var uniqueProviders = ImmutableHashSet.CreateBuilder<EventPipeProvider>(EventPipeProviderEqualityComparer.Instance);
 
@@ -154,7 +156,16 @@ private sealed class EventPipeProviderEqualityComparer : IEqualityComparer<Event
         {
             internal static readonly IEqualityComparer<EventPipeProvider> Instance = new EventPipeProviderEqualityComparer();
 
-            public bool Equals(EventPipeProvider x, EventPipeProvider y) => x.Name.Equals(y.Name);
+            public bool Equals(EventPipeProvider? x, EventPipeProvider? y)
+            {
+                if (ReferenceEquals(x, y))
+                    return true;
+
+                if (x is null || y is null)
+                    return false;
+
+                return x.Name.Equals(y.Name);
+            }
 
             public int GetHashCode(EventPipeProvider obj) => obj.Name.GetHashCode();
         }