Skip to content

Commit 296fcc5

Browse files
committed
Update notes_cross_staff.lua
Corrected a significant error in key command replacement logic.
1 parent 9ec35e5 commit 296fcc5

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

src/notes_cross_staff.lua

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ function plugindef()
44
finaleplugin.Author = "Carl Vine"
55
finaleplugin.AuthorURL = "https://carlvine.com/lua/"
66
finaleplugin.Copyright = "https://creativecommons.org/licenses/by/4.0/"
7-
finaleplugin.Version = "0.95k"
8-
finaleplugin.Date = "2024/07/23"
7+
finaleplugin.Version = "0.95l"
8+
finaleplugin.Date = "2024/08/10"
99
finaleplugin.MinJWLuaVersion = 0.74
1010
finaleplugin.ScriptGroupDescription = "Selected notes are cross-staffed to the next staff above or below"
1111
finaleplugin.Notes = [[
@@ -82,6 +82,12 @@ local hotkey = { -- customise Key Commands (lowercase only)
8282
a = "a",
8383
s = "s",
8484
}
85+
local checks = { -- checkbox key; text description (ordered)
86+
{ "rest_fill", "Add Invisible Rest To Empty Destination" },
87+
{ "not_unbeamed", "Don't Cross Unbeamed Notes" },
88+
{ "reversing", "Reverse Stems For Mid-Staff Beams" },
89+
{ "whole_measure", "Shift Horizontals Across Whole Measure" }
90+
}
8591
local config = {
8692
rest_fill = true, -- fill destination with invisible rest
8793
not_unbeamed = true, -- true to prevent unbeamed notes
@@ -107,12 +113,6 @@ local offsets = { -- (ordered) name; default value; text description; h_offset
107113
-- copy default offset values to config
108114
for _, v in ipairs(offsets) do config[v[1]] = v[2] end
109115

110-
local checks = { -- checkbox key; text description (ordered)
111-
{ "rest_fill", "Add Invisible Rest To Empty Destination" },
112-
{ "not_unbeamed", "Don't Cross Unbeamed Notes" },
113-
{ "reversing", "Reverse Stems For Mid-Staff Beams" },
114-
{ "whole_measure", "Shift Horizontals Across Whole Measure" }
115-
}
116116
local entry_text = { "note", "notes" }
117117
local pattern = {
118118
{ "count_notes", "Cross", 37 },
@@ -500,7 +500,7 @@ local function run_the_dialog()
500500
if (s:find("p") and dialog:GetMeasurementUnit() ~= finale.MEASUREMENTUNIT_PICAS)
501501
or s:find("[^-.p0-9]")
502502
or (id == "layer_num" and s:find("[^0-" .. max .. "]"))
503-
or (id:find("count") and s:find("[^1-9]"))
503+
or (id:find("count") and s:find("[-.p0]"))
504504
then
505505
if s:find("[eicoas]") then -- change UNITS
506506
for k, v in pairs(units) do
@@ -523,9 +523,7 @@ local function run_the_dialog()
523523
for k, v in pairs(hotkey) do
524524
if s:find(v) then
525525
answer[k]:SetCheck((answer[k]:GetCheck() + 1) % 2)
526-
if k == "reversing" then set_offset_disable()
527-
else answer[k]:SetCheck((answer[k]:GetCheck() + 1) % 2)
528-
end
526+
if k == "reversing" then set_offset_disable() end
529527
break
530528
end
531529
end

0 commit comments

Comments
 (0)