Implementation of cansplitpush, repeat_operator, replace_and_remove_nodes and find_lowest_nodes #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@kylebd99 I have changed the codebase as requested. |
kylebd99
approved these changes
Dec 2, 2025
Contributor
kylebd99
left a comment
kylebd99
left a comment
There was a problem hiding this comment.
Hey, sorry for the slow review, I think everything looks good. I had a couple of very minor comments, but I'm going to go ahead and approve it. Please make the changes, then go ahead and merge.
| ["A"], | ||
| ), | ||
| # Nested case: | ||
| # root = MapJoin(mul, [A(i,j), B(i)]), reduce over i → [A] |
Contributor
There was a problem hiding this comment.
Nit: I think you mean B(j) in this comment.
Contributor
There was a problem hiding this comment.
Further, I'd appreciate 1 additional nested case where B has the index "i" which returns the mapjoin as the lowest root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I have implemented cansplitpush, repeat_operator, replace_and_remove_nodes and find_lowest_nodes and have written test for every one of the functions. I have changed the backbone of annotated_query to make its semantic clearer. I have also file an issue for each function.
Fix #241, Fix #242, Fix #243 & Fix #244
Thank you for your time!!