Skip to content

Commit f908c8d

Browse files
committed
Fix possible out-of-bounds write, found by Coverity Scan
Signed-off-by: Joachim Wiberg <[email protected]>
1 parent 308f75b commit f908c8d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/service.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -747,7 +747,7 @@ static int service_start(svc_t *svc)
747747
}
748748
} else { /* pid == 0 */
749749
char str[strlen(NOTIFY_PATH) + 32];
750-
char *args[MAX_NUM_SVC_ARGS + 1];
750+
char *args[MAX_NUM_SVC_ARGS + 3];
751751
int status;
752752

753753
if (!svc_is_tty(svc))
@@ -1146,12 +1146,12 @@ int service_stop(svc_t *svc)
11461146
svc_set_state(svc, SVC_HALTED_STATE);
11471147
}
11481148
} else {
1149-
char *args[MAX_NUM_SVC_ARGS + 1];
1149+
char *args[MAX_NUM_SVC_ARGS + 3];
11501150
size_t i = 0, j;
11511151

11521152
args[i++] = svc->cmd;
11531153
/* this handles, e.g., bridge-stop br0 stop */
1154-
for (j = 0; j < MAX_NUM_SVC_ARGS - 2; j++) {
1154+
for (j = 0; j < MAX_NUM_SVC_ARGS; j++) {
11551155
if (!strlen(svc->args[j]))
11561156
break;
11571157
args[i++] = svc->args[j];

0 commit comments

Comments
 (0)