Merge pull request #1866 from rocketstack-matt/fix/shared-incomplete-string-escaping

LeighFinegold · web-flow · commit 5548fa6ea87f · 2025-11-27T14:46:19.000Z
fix(shared): escape backslashes before quotes in template preprocessor
diff --git a/shared/src/template/template-preprocessor.ts b/shared/src/template/template-preprocessor.ts
@@ -385,7 +385,7 @@ export class TemplatePreprocessor {
             return { decision: { kind: 'leave', seg, reason: 'native-handlebars-path' } };
         }
 
-        const safePath = path.replace(/"/g, '\\"');
+        const safePath = path.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
         const { kvs, positionals } = TemplatePreprocessor.splitExtrasFromString(extras);
         const kvsPart = kvs.length ? ` ${kvs.join(' ')}` : '';
         const posPart = positionals.length ? ` ${positionals.join(' ')}` : '';

Original file line number	Diff line number	Diff line change
`@@ -385,7 +385,7 @@ export class TemplatePreprocessor {`
`385`	`385`	`return { decision: { kind: 'leave', seg, reason: 'native-handlebars-path' } };`
`386`	`386`	`}`
`387`	`387`
`388`		`- const safePath = path.replace(/"/g, '\\"');`
	`388`	`+ const safePath = path.replace(/\\/g, '\\\\').replace(/"/g, '\\"');`
`389`	`389`	`const { kvs, positionals } = TemplatePreprocessor.splitExtrasFromString(extras);`
`390`	`390`	const kvsPart = kvs.length ? ` ${kvs.join(' ')}` : '';
`391`	`391`	const posPart = positionals.length ? ` ${positionals.join(' ')}` : '';