Skip to content

Commit 36f5506

Browse files
Add Azure Trusted Signing (#80)
2 parents 0e9a85c + 05e8cf7 commit 36f5506

File tree

4 files changed

+47
-12
lines changed

4 files changed

+47
-12
lines changed

.github/workflows/RELEASE.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,13 @@ jobs:
9292
if: ${{ runner.os == 'Windows' }}
9393
env:
9494
BUILD_REF: ${{ github.ref_name }}
95-
CSC_LINK: "${{ secrets.WIN_CSC_LINK }}"
96-
CSC_KEY_PASSWORD: "${{ secrets.WIN_CSC_KEY_PASSWORD }}"
95+
AZURE_CERT_PROFILE_NAME: "${{ secrets.AZURE_CERT_PROFILE_NAME }}"
96+
AZURE_CLIENT_ID: "${{ secrets.AZURE_CLIENT_ID }}"
97+
AZURE_CLIENT_SECRET: "${{ secrets.AZURE_CLIENT_SECRET }}"
98+
AZURE_CODE_SIGNING_NAME: "${{ secrets.AZURE_CODE_SIGNING_NAME }}"
99+
AZURE_ENDPOINT: "${{ secrets.AZURE_ENDPOINT }}"
100+
AZURE_PUBLISHER_NAME: "${{ secrets.AZURE_PUBLISHER_NAME }}"
101+
AZURE_TENANT_ID: "${{ secrets.AZURE_TENANT_ID }}"
97102
IS_CI: true
98103
MIXPANEL_TOKEN: "${{ secrets.MIXPANEL_PROJECT_TOKEN }}"
99104
MIXPANEL_STAGE: "prod"

package-lock.json

Lines changed: 28 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,4 +100,4 @@
100100
]
101101
]
102102
}
103-
}
103+
}

tasks/distro.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,17 @@ const signingOptions = [
9999
`-c.forceCodeSigning=${false}`
100100
];
101101

102-
const certificateFingerprint = process.env.WIN_CSC_FINGERPRINT;
103-
if (certificateFingerprint) {
104-
signingOptions.push(`-c.win.certificateSha1=${certificateFingerprint}`);
102+
const windowsSigningOptions = {
103+
certificateProfileName: process.env.AZURE_CERT_PROFILE_NAME,
104+
endpoint: process.env.AZURE_ENDPOINT,
105+
codeSigningAccountName: process.env.AZURE_CODE_SIGNING_NAME,
106+
publisherName: process.env.AZURE_PUBLISHER_NAME
107+
};
108+
109+
for (const [ key, value ] of Object.entries(windowsSigningOptions)) {
110+
if (value) {
111+
signingOptions.push(`-c.win.azureSignOptions.${key}=${value}`);
112+
}
105113
}
106114

107115
if (publish && (argv.ia32 || argv.x64 || argv.arm64)) {

0 commit comments

Comments
 (0)