fix: fix blocked request test

Author: fabiovincenzi

src/proxy/routes/index.ts

@@ -74,13 +74,20 @@ const teeAndValidate = async (req: Request, res: Response, next: NextFunction) =
     (req as any).body = buf;
     const verdict = await executeChain(req, res);
     console.log('action processed');
-
     if (verdict.error || verdict.blocked) {
-      const msg = verdict.error ? verdict.errorMessage! : verdict.blockedMessage!;
+      let msg = '';
+
+      if (verdict.error) {
+        msg = verdict.errorMessage!;
+        console.error(msg);
+      }
+      if (verdict.blocked) {
+        msg = verdict.blockedMessage!;
+      }
+
       res
         .set({
           'content-type': 'application/x-git-receive-pack-result',
-          'transfer-encoding': 'chunked',
           expires: 'Fri, 01 Jan 1980 00:00:00 GMT',
           pragma: 'no-cache',
           'cache-control': 'no-cache, max-age=0, must-revalidate',

test/testProxyRoute.test.js

@@ -42,9 +42,10 @@ describe('proxy route filter middleware', () => {
 
     const res = await chai
       .request(app)
-      .get('/owner/repo.git/info/refs?service=git-upload-pack')
+      .post('/owner/repo.git/git-upload-pack')
       .set('user-agent', 'git/2.42.0')
       .set('accept', 'application/x-git-upload-pack-request')
+      .send(Buffer.from('0000'))
       .buffer();
 
     expect(res.status).to.equal(200);
@@ -112,49 +113,49 @@ describe('proxy route helpers', () => {
       });
       expect(res).to.be.true;
     });
-  
+
     it('should return true for /info/refs?service=git-receive-pack with valid user-agent', () => {
       const res = validGitRequest('/info/refs?service=git-receive-pack', {
         'user-agent': 'git/1.9.1',
       });
       expect(res).to.be.true;
     });
-  
+
     it('should return false for /info/refs?service=git-upload-pack with missing user-agent', () => {
       const res = validGitRequest('/info/refs?service=git-upload-pack', {});
       expect(res).to.be.false;
     });
-  
+
     it('should return false for /info/refs?service=git-upload-pack with non-git user-agent', () => {
       const res = validGitRequest('/info/refs?service=git-upload-pack', {
         'user-agent': 'curl/7.79.1',
       });
       expect(res).to.be.false;
     });
-  
+
     it('should return true for /git-upload-pack with valid user-agent and accept', () => {
       const res = validGitRequest('/git-upload-pack', {
         'user-agent': 'git/2.40.0',
         accept: 'application/x-git-upload-pack-request',
       });
       expect(res).to.be.true;
     });
-  
+
     it('should return false for /git-upload-pack with missing accept header', () => {
       const res = validGitRequest('/git-upload-pack', {
         'user-agent': 'git/2.40.0',
       });
       expect(res).to.be.false;
     });
-  
+
     it('should return false for /git-upload-pack with wrong accept header', () => {
       const res = validGitRequest('/git-upload-pack', {
         'user-agent': 'git/2.40.0',
         accept: 'application/json',
       });
       expect(res).to.be.false;
     });
-  
+
     it('should return false for unknown paths', () => {
       const res = validGitRequest('/not-a-valid-git-path', {
         'user-agent': 'git/2.40.0',
@@ -169,32 +170,32 @@ describe('proxy route helpers', () => {
       const res = stripGitHubFromGitPath('/foo/bar.git/info/refs');
       expect(res).to.equal('/info/refs');
     });
-  
+
     it('should strip owner and repo from a valid GitHub-style path with 5 parts', () => {
       const res = stripGitHubFromGitPath('/foo/bar.git/git-upload-pack');
       expect(res).to.equal('/git-upload-pack');
     });
-  
+
     it('should return undefined for malformed path with too few segments', () => {
       const res = stripGitHubFromGitPath('/foo/bar.git');
       expect(res).to.be.undefined;
     });
-  
+
     it('should return undefined for malformed path with too many segments', () => {
       const res = stripGitHubFromGitPath('/foo/bar.git/extra/path/stuff');
       expect(res).to.be.undefined;
     });
-  
+
     it('should handle repo names that include dots correctly', () => {
       const res = stripGitHubFromGitPath('/foo/some.repo.git/info/refs');
       expect(res).to.equal('/info/refs');
     });
-  
+
     it('should not break if the path is just a slash', () => {
       const res = stripGitHubFromGitPath('/');
       expect(res).to.be.undefined;
     });
-  
+
     it('should not break if the path is empty', () => {
       const res = stripGitHubFromGitPath('');
       expect(res).to.be.undefined;