Skip to content

Commit 41dbc46

Browse files
authored
Merge pull request #1059 from jescalada/upgrade-node-to-20.19
chore: upgrade node in CI to 20.19
2 parents e7ee0d6 + 770b7d1 commit 41dbc46

File tree

6 files changed

+8
-96
lines changed

6 files changed

+8
-96
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
strategy:
2121
matrix:
22-
node-version: [18.x]
22+
node-version: [20.x]
2323
mongodb-version: [4.4]
2424

2525
steps:

.github/workflows/experimental-inventory-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919

2020
strategy:
2121
matrix:
22-
node-version: [18.x]
22+
node-version: [20.x]
2323
mongodb-version: [4.4]
2424

2525
steps:

.github/workflows/lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ name: Code Cleanliness
22

33
on: [pull_request]
44

5-
env: # environment variables (available in any part of the action)
6-
NODE_VERSION: 18
5+
env:
6+
NODE_VERSION: 20
77

88
permissions:
99
contents: read

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
# - uses: actions/checkout@8459bc0 # v4
5353
# - uses: actions/setup-node@c2ac33f # v4, Setup .npmrc file to publish to npm
5454
# with:
55-
# node-version: '18.x'
55+
# node-version: '20.x'
5656
# registry-url: 'https://registry.npmjs.org'
5757
# - run: npm ci
5858
# - run: npm publish --access=public

test/plugin/plugin.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,15 +23,15 @@ describe('loading plugins from packages', function () {
2323
spawnSync('npm', ['install'], { cwd: testPackagePath, timeout: 5000 });
2424
});
2525

26-
it.skip('should load plugins that are the default export (module.exports = pluginObj)', async function () {
26+
it('should load plugins that are the default export (module.exports = pluginObj)', async function () {
2727
const loader = new PluginLoader([join(testPackagePath, 'default-export.js')]);
2828
await loader.load();
2929
expect(loader.pushPlugins.length).to.equal(1);
3030
expect(loader.pushPlugins.every((p) => isCompatiblePlugin(p))).to.be.true;
3131
expect(loader.pushPlugins[0]).to.be.an.instanceOf(PushActionPlugin);
3232
}).timeout(10000);
3333

34-
it.skip('should load multiple plugins from a module that match the plugin class (module.exports = { pluginFoo, pluginBar })', async function () {
34+
it('should load multiple plugins from a module that match the plugin class (module.exports = { pluginFoo, pluginBar })', async function () {
3535
const loader = new PluginLoader([join(testPackagePath, 'multiple-export.js')]);
3636
await loader.load();
3737
expect(loader.pushPlugins.length).to.equal(1);
@@ -45,7 +45,7 @@ describe('loading plugins from packages', function () {
4545
expect(loader.pullPlugins[0]).to.be.instanceOf(PullActionPlugin);
4646
}).timeout(10000);
4747

48-
it.skip('should load plugins that are subclassed from plugin classes', async function () {
48+
it('should load plugins that are subclassed from plugin classes', async function () {
4949
const loader = new PluginLoader([join(testPackagePath, 'subclass.js')]);
5050
await loader.load();
5151
expect(loader.pushPlugins.length).to.equal(1);

test/testUserCreation.test.js

Lines changed: 0 additions & 88 deletions
This file was deleted.

0 commit comments

Comments
 (0)