revert unused files and http support

Author: coopernetes

src/db/file/users.ts

@@ -1,9 +1,16 @@
+import fs from 'fs';
 import Datastore from '@seald-io/nedb';
 
 import { User, UserQuery } from '../types';
 
 const COMPACTION_INTERVAL = 1000 * 60 * 60 * 24; // once per day
 
+// these don't get coverage in tests as they have already been run once before the test
+/* istanbul ignore if */
+if (!fs.existsSync('./.data')) fs.mkdirSync('./.data');
+/* istanbul ignore if */
+if (!fs.existsSync('./.data/db')) fs.mkdirSync('./.data/db');
+
 // export for testing purposes
 export let db: Datastore;
 if (process.env.NODE_ENV === 'test') {

src/proxy/processors/pre-processor/parseAction.ts

@@ -26,30 +26,16 @@ const exec = async (req: {
   const pathBreakdown = processUrlPath(req.originalUrl);
   let url = 'https:/' + (pathBreakdown?.repoPath ?? 'NOT-FOUND');
 
-  // First, try to find a matching repository by checking both http:// and https:// protocols
-  const repoPath = pathBreakdown?.repoPath ?? 'NOT-FOUND';
-  const httpsUrl = 'https:/' + repoPath;
-  const httpUrl = 'http:/' + repoPath;
-
-  console.log(
-    `Parse action trying HTTPS repo URL: ${httpsUrl} for inbound URL path: ${req.originalUrl}`,
-  );
-
-  if (await db.getRepoByUrl(httpsUrl)) {
-    url = httpsUrl;
-  } else {
+  console.log(`Parse action calculated repo URL: ${url} for inbound URL path: ${req.originalUrl}`);
+
+  if (!(await db.getRepoByUrl(url))) {
+    // fallback for legacy proxy URLs
+    // legacy git proxy paths took the form: https://<git proxy domain>:<port>/<repoPath>
+    // by assuming the host was github.com
+    url = 'https://github.com' + (pathBreakdown?.repoPath ?? 'NOT-FOUND');
     console.log(
-      `Parse action trying HTTP repo URL: ${httpUrl} for inbound URL path: ${req.originalUrl}`,
+      `Parse action fallback calculated repo URL: ${url} for inbound URL path: ${req.originalUrl}`,
     );
-    if (await db.getRepoByUrl(httpUrl)) {
-      url = httpUrl;
-    } else {
-      // fallback for legacy proxy URLs - try github.com with https
-      url = 'https://github.com' + repoPath;
-      console.log(
-        `Parse action fallback calculated repo URL: ${url} for inbound URL path: ${req.originalUrl}`,
-      );
-    }
   }
 
   return new Action(id.toString(), type, req.method, timestamp, url);

src/service/routes/repo.ts

@@ -163,9 +163,9 @@ const repo = (proxy: any) => {
           let newOrigin = true;
 
           const existingHosts = await getAllProxiedHosts();
-          existingHosts.forEach((host) => {
-            // Check if the request URL contains this host
-            if (req.body.url.includes(host)) {
+          existingHosts.forEach((h) => {
+            // assume SSL is in use and that our origins are missing the protocol
+            if (req.body.url.startsWith(`https://${h}`)) {
               newOrigin = false;
             }
           });