chore: improve 401 error messages and normalize GitProxy spelling

Author: jescalada

SSH.md

@@ -1,4 +1,4 @@
-### SSH Git Proxy Data Flow
+### GitProxy SSH Data Flow
 
 1.  **Client Connection:**
     - An SSH client (e.g., `git` command line) connects to the proxy server's listening port.

config.schema.json

@@ -7,7 +7,7 @@
   "properties": {
     "proxyUrl": {
       "type": "string",
-      "description": "Deprecated: Used in early versions of git proxy to configure the remote host that traffic is proxied to. In later versions, the repository URL is used to determine the domain proxied, allowing multiple hosts to be proxied by one instance.",
+      "description": "Deprecated: Used in early versions of GitProxy to configure the remote host that traffic is proxied to. In later versions, the repository URL is used to determine the domain proxied, allowing multiple hosts to be proxied by one instance.",
       "deprecated": true
     },
     "cookieSecret": { "type": "string" },
@@ -210,7 +210,7 @@
       "required": []
     },
     "domains": {
-      "description": "Provide custom URLs for the git proxy interfaces in case it cannot determine its own URL",
+      "description": "Provide custom URLs for the GitProxy interfaces in case it cannot determine its own URL",
       "type": "object",
       "properties": {
         "proxy": {
@@ -448,7 +448,7 @@
             },
             "userGroup": {
               "type": "string",
-              "description": "Group that indicates that a user should be able to login to the Git Proxy UI and can work as a reviewer"
+              "description": "Group that indicates that a user should be able to login to the GitProxy UI and can work as a reviewer"
             },
             "domain": { "type": "string", "description": "Active Directory domain" },
             "adConfig": {

cypress/e2e/login.cy.js

@@ -3,7 +3,7 @@ describe('Login page', () => {
     cy.visit('/login');
   });
 
-  it('should have git proxy logo', () => {
+  it('should have GitProxy logo', () => {
     cy.get('[data-test="git-proxy-logo"]').should('exist');
   });
 

docs/SSH_KEY_RETENTION.md

@@ -1,12 +1,12 @@
-# SSH Key Retention for Git Proxy
+# SSH Key Retention for GitProxy
 
 ## Overview
 
-This document describes the SSH key retention feature that allows Git Proxy to securely store and reuse user SSH keys during the approval process, eliminating the need for users to re-authenticate when their push is approved.
+This document describes the SSH key retention feature that allows GitProxy to securely store and reuse user SSH keys during the approval process, eliminating the need for users to re-authenticate when their push is approved.
 
 ## Problem Statement
 
-Previously, when a user pushes code via SSH to Git Proxy:
+Previously, when a user pushes code via SSH to GitProxy:
 
 1. User authenticates with their SSH key
 2. Push is intercepted and requires approval

packages/git-proxy-cli/index.ts

@@ -203,7 +203,7 @@ async function authoriseGitPush(id: string) {
     if (error.response) {
       switch (error.response.status) {
         case 401:
-          errorMessage = 'Error: Authorise: Authentication required';
+          errorMessage = `Error: Authorise: Authentication required: '${error.response.data.message}'`;
           process.exitCode = 3;
           break;
         case 404:
@@ -250,7 +250,7 @@ async function rejectGitPush(id: string) {
     if (error.response) {
       switch (error.response.status) {
         case 401:
-          errorMessage = 'Error: Reject: Authentication required';
+          errorMessage = `Error: Reject: Authentication required: '${error.response.data.message}'`;
           process.exitCode = 3;
           break;
         case 404:
@@ -297,7 +297,7 @@ async function cancelGitPush(id: string) {
     if (error.response) {
       switch (error.response.status) {
         case 401:
-          errorMessage = 'Error: Cancel: Authentication required';
+          errorMessage = `Error: Cancel: Authentication required: '${error.response.data.message}'`;
           process.exitCode = 3;
           break;
         case 404:
@@ -372,7 +372,7 @@ async function addSSHKey(username: string, keyPath: string) {
     if (error.response) {
       switch (error.response.status) {
         case 401:
-          errorMessage = 'Error: SSH key: Authentication required';
+          errorMessage = `Error: SSH key: Authentication required: '${error.response.data.message}'`;
           process.exitCode = 3;
           break;
         case 404:

src/config/generated/config.ts

@@ -52,7 +52,7 @@ export interface GitProxyConfig {
    */
   csrfProtection?: boolean;
   /**
-   * Provide custom URLs for the git proxy interfaces in case it cannot determine its own URL
+   * Provide custom URLs for the GitProxy interfaces in case it cannot determine its own URL
    */
   domains?: Domains;
   /**
@@ -70,7 +70,7 @@ export interface GitProxyConfig {
    */
   privateOrganizations?: any[];
   /**
-   * Deprecated: Used in early versions of git proxy to configure the remote host that traffic
+   * Deprecated: Used in early versions of GitProxy to configure the remote host that traffic
    * is proxied to. In later versions, the repository URL is used to determine the domain
    * proxied, allowing multiple hosts to be proxied by one instance.
    */
@@ -184,7 +184,7 @@ export interface AuthenticationElement {
    */
   domain?: string;
   /**
-   * Group that indicates that a user should be able to login to the Git Proxy UI and can work
+   * Group that indicates that a user should be able to login to the GitProxy UI and can work
    * as a reviewer
    */
   userGroup?: string;
@@ -414,7 +414,7 @@ export interface MessageBlock {
 }
 
 /**
- * Provide custom URLs for the git proxy interfaces in case it cannot determine its own URL
+ * Provide custom URLs for the GitProxy interfaces in case it cannot determine its own URL
  */
 export interface Domains {
   /**

src/service/index.ts

@@ -28,7 +28,7 @@ const corsOptions = {
 };
 
 /**
- * Internal function used to bootstrap the Git Proxy API's express application.
+ * Internal function used to bootstrap GitProxy's API express application.
  * @param {Proxy} proxy A reference to the proxy, used to restart it when necessary.
  * @return {Promise<Express>} the express application
  */