fix(ts): fix TS linter issues

Author: jescalada

src/db/file/repo.ts

@@ -1,14 +1,13 @@
 import fs from 'fs';
 import Datastore from '@seald-io/nedb'
-import { Action } from '../../proxy/actions/Action';
 import { Repo } from '../types';
 
 if (!fs.existsSync('./.data')) fs.mkdirSync('./.data');
 if (!fs.existsSync('./.data/db')) fs.mkdirSync('./.data/db');
 
 const db = new Datastore({ filename: './.data/db/repos.db', autoload: true });
 
-export const getRepos = async (query = {}) => {
+export const getRepos = async () => {
   return new Promise<Repo[]>((resolve, reject) => {
     db.find({}, (err: Error, docs: Repo[]) => {
       if (err) {
@@ -157,7 +156,7 @@ export const deleteRepo = async (name: string) => {
 
 export const isUserPushAllowed = async (name: string, user: string) => {
   name = name.toLowerCase();
-  return new Promise<boolean>(async (resolve, reject) => {
+  return new Promise<boolean>(async (resolve) => {
     const repo = await exports.getRepo(name);
     console.log(repo.users.canPush);
     console.log(repo.users.canAuthorise);
@@ -173,7 +172,7 @@ export const isUserPushAllowed = async (name: string, user: string) => {
 export const canUserApproveRejectPushRepo = async (name: string, user: string) => {
   name = name.toLowerCase();
   console.log(`checking if user ${user} can approve/reject for ${name}`);
-  return new Promise<boolean>(async (resolve, reject) => {
+  return new Promise<boolean>(async (resolve) => {
     const repo = await exports.getRepo(name);
     if (repo.users.canAuthorise.includes(user)) {
       console.log(`user ${user} can approve/reject to repo ${name}`);

src/db/mongo/repo.ts

@@ -7,7 +7,7 @@ const isBlank = (str: string) => {
   return !str || /^\s*$/.test(str);
 };
 
-export const getRepos = async (query = {}) => {
+export const getRepos = async () => {
   const collection = await connect(collectionName);
   return collection.find().toArray();
 };
@@ -71,7 +71,7 @@ export const deleteRepo = async (name: string) => {
 
 export const isUserPushAllowed = async (name: string, user: string) => {
   name = name.toLowerCase();
-  return new Promise(async (resolve, reject) => {
+  return new Promise(async (resolve) => {
     const repo = await exports.getRepo(name);
     console.log(repo.users.canPush);
     console.log(repo.users.canAuthorise);
@@ -87,7 +87,7 @@ export const isUserPushAllowed = async (name: string, user: string) => {
 export const canUserApproveRejectPushRepo = async (name: string, user: string) => {
   name = name.toLowerCase();
   console.log(`checking if user ${user} can approve/reject for ${name}`);
-  return new Promise(async (resolve, reject) => {
+  return new Promise(async (resolve) => {
     const repo = await exports.getRepo(name);
     if (repo.users.canAuthorise.includes(user)) {
       console.log(`user ${user} can approve/reject to repo ${name}`);

src/plugin.js

@@ -1,4 +1,5 @@
 const lpModule = import('load-plugin');
+/* eslint-disable @typescript-eslint/no-unused-expressions */
 ('use strict');
 
 /**

src/proxy/actions/Action.js

@@ -62,10 +62,9 @@ class Action {
 
   /**
    *
-   * @param {*} step
    * @return {Step}
    */
-  getLastStep(step) {
+  getLastStep() {
     return this.lastStep;
   }
 

src/proxy/routes/index.js

@@ -106,7 +106,7 @@ router.use(
       console.log('Sending request to ' + url);
       return url;
     },
-    proxyReqOptDecorator: function (proxyReqOpts, srcReq) {
+    proxyReqOptDecorator: function (proxyReqOpts) {
       return proxyReqOpts;
     },
 

src/service/routes/auth.js

@@ -98,7 +98,7 @@ router.post('/gitAccount', async (req, res) => {
       user.gitAccount = req.body.gitAccount;
       db.updateUser(user);
       res.status(200).end();
-    } catch (e) {
+    } catch {
       res
         .status(500)
         .send({

src/ui/components/Footer/Footer.jsx

@@ -7,7 +7,7 @@ import { MarkGithubIcon } from '@primer/octicons-react';
 
 const useStyles = makeStyles(styles);
 
-export default function Footer(props) {
+export default function Footer() {
   const classes = useStyles();
   return (
     <footer className={classes.footer}>

src/ui/layouts/Admin.jsx

@@ -76,8 +76,8 @@ export default function Admin({ ...rest }) {
 
     // Specify how to clean up after this effect:
     return function cleanup() {
-      if (navigator.platform.indexOf('Win') > -1) {
-        ps && ps.destroy();
+      if (navigator.platform.indexOf('Win') > -1 && ps) {
+        ps.destroy();
       }
       window.removeEventListener('resize', resizeFunction);
     };

src/ui/views/RepoList/Components/NewRepo.jsx

@@ -65,7 +65,7 @@ function AddRepositoryDialog(props) {
 
     try {
       new URL(data.url);
-    } catch (e) {
+    } catch {
       setError('Invalid URL');
       return;
     }

src/ui/views/RepoList/RepoList.jsx

@@ -3,7 +3,7 @@ import GridItem from '../../components/Grid/GridItem';
 import GridContainer from '../../components/Grid/GridContainer';
 import TabList from './Components/TabList';
 
-export default function RepoList(props) {
+export default function RepoList() {
   return (
     <GridContainer>
       <GridItem xs={12} sm={12} md={12}>