Skip to content

Commit 8711aa5

Browse files
committed
fix: correct typing for ConfigLoader env
Was providing a number which can be coerced to a string but TS is a bit more strict asking for string values for env. Also swapped 0 to false to be more clear and added a docs link.
1 parent cfc069c commit 8711aa5

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/config/ConfigLoader.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,8 @@ export class ConfigLoader extends EventEmitter {
317317
cwd: process.cwd(),
318318
env: {
319319
// dont wait for credentials; the command should be sufficiently authed
320-
GIT_TERMINAL_PROMPT: 0,
320+
// https://git-scm.com/docs/git#Documentation/git.txt-codeGITTERMINALPROMPTcode
321+
GIT_TERMINAL_PROMPT: 'false',
321322
...process.env,
322323
...(source.auth?.type === 'ssh'
323324
? {

0 commit comments

Comments
 (0)