chore: remove unnecessary logging in push actions and routes

Author: jescalada

src/proxy/processors/push-action/checkAuthorEmails.ts

@@ -35,15 +35,10 @@ const exec = async (req: any, action: Action): Promise<Action> => {
   const uniqueAuthorEmails = [
     ...new Set(action.commitData?.map((commitData: CommitData) => commitData.authorEmail)),
   ];
-  console.log({ uniqueAuthorEmails });
 
   const illegalEmails = uniqueAuthorEmails.filter((email) => !isEmailAllowed(email));
-  console.log({ illegalEmails });
 
-  const usingIllegalEmails = illegalEmails.length > 0;
-  console.log({ usingIllegalEmails });
-
-  if (usingIllegalEmails) {
+  if (illegalEmails.length > 0) {
     console.log(`The following commit author e-mails are illegal: ${illegalEmails}`);
 
     step.error = true;

src/proxy/processors/push-action/checkCommitMessages.ts

@@ -5,8 +5,6 @@ const isMessageAllowed = (commitMessage: string): boolean => {
   try {
     const commitConfig = getCommitConfig();
 
-    console.log(`isMessageAllowed(${commitMessage})`);
-
     // Commit message is empty, i.e. '', null or undefined
     if (!commitMessage) {
       console.log('No commit message included...');
@@ -19,26 +17,21 @@ const isMessageAllowed = (commitMessage: string): boolean => {
       return false;
     }
 
-    // Configured blocked literals
+    // Configured blocked literals and patterns
     const blockedLiterals: string[] = commitConfig.message?.block?.literals ?? [];
-
-    // Configured blocked patterns
     const blockedPatterns: string[] = commitConfig.message?.block?.patterns ?? [];
 
-    // Find all instances of blocked literals in commit message...
+    // Find all instances of blocked literals and patterns in commit message
     const positiveLiterals = blockedLiterals.map((literal: string) =>
       commitMessage.toLowerCase().includes(literal.toLowerCase()),
     );
 
-    // Find all instances of blocked patterns in commit message...
     const positivePatterns = blockedPatterns.map((pattern: string) =>
       commitMessage.match(new RegExp(pattern, 'gi')),
     );
 
-    // Flatten any positive literal results into a 1D array...
+    // Flatten any positive literal and pattern results into a 1D array
     const literalMatches = positiveLiterals.flat().filter((result) => !!result);
-
-    // Flatten any positive pattern results into a 1D array...
     const patternMatches = positivePatterns.flat().filter((result) => !!result);
 
     // Commit message matches configured block pattern(s)
@@ -59,15 +52,10 @@ const exec = async (req: any, action: Action): Promise<Action> => {
   const step = new Step('checkCommitMessages');
 
   const uniqueCommitMessages = [...new Set(action.commitData?.map((commit) => commit.message))];
-  console.log({ uniqueCommitMessages });
 
   const illegalMessages = uniqueCommitMessages.filter((message) => !isMessageAllowed(message));
-  console.log({ illegalMessages });
-
-  const usingIllegalMessages = illegalMessages.length > 0;
-  console.log({ usingIllegalMessages });
 
-  if (usingIllegalMessages) {
+  if (illegalMessages.length > 0) {
     console.log(`The following commit messages are illegal: ${illegalMessages}`);
 
     step.error = true;

src/proxy/processors/push-action/parsePush.ts

@@ -222,8 +222,6 @@ const getCommitData = (contents: CommitContent[]): CommitData[] => {
     .chain(contents)
     .filter({ type: GIT_OBJECT_TYPE_COMMIT })
     .map((x: CommitContent) => {
-      console.log({ x });
-
       const allLines = x.content.split('\n');
       let headerEndIndex = -1;
 
@@ -246,7 +244,6 @@ const getCommitData = (contents: CommitContent[]): CommitData[] => {
         .slice(headerEndIndex + 1)
         .join('\n')
         .trim();
-      console.log({ headerLines, message });
 
       const { tree, parents, author, committer } = getParsedData(headerLines);
       // No parent headers -> zero hash

src/service/routes/push.ts

@@ -69,7 +69,6 @@ router.post('/:id/reject', async (req: Request, res: Response) => {
   }
 
   const isAllowed = await db.canUserApproveRejectPush(id, username);
-  console.log({ isAllowed });
 
   if (isAllowed) {
     const result = await db.reject(id, null);
@@ -84,25 +83,19 @@ router.post('/:id/reject', async (req: Request, res: Response) => {
 
 router.post('/:id/authorise', async (req: Request, res: Response) => {
   const questions = req.body.params?.attestation;
-  console.log({ questions });
 
   // TODO: compare attestation to configuration and ensure all questions are answered
   // - we shouldn't go on the definition in the request!
   const attestationComplete = questions?.every(
     (question: { checked: boolean }) => !!question.checked,
   );
-  console.log({ attestationComplete });
 
   if (req.user && attestationComplete) {
     const id = req.params.id;
-    console.log({ id });
 
     const { username } = req.user as { username: string };
 
-    // Get the push request
     const push = await db.getPush(id);
-    console.log({ push });
-
     if (!push) {
       res.status(404).send({
         message: 'Push request not found',
@@ -114,7 +107,6 @@ router.post('/:id/authorise', async (req: Request, res: Response) => {
     const committerEmail = push.userEmail;
 
     const list = await db.getUsers({ email: committerEmail });
-    console.log({ list });
 
     if (list.length === 0) {
       res.status(401).send({
@@ -196,7 +188,6 @@ router.post('/:id/cancel', async (req: Request, res: Response) => {
 async function getValidPushOrRespond(id: string, res: Response) {
   console.log('getValidPushOrRespond', { id });
   const push = await db.getPush(id);
-  console.log({ push });
 
   if (!push) {
     res.status(404).send({ message: `Push request not found` });

src/ui/views/PushDetails/PushDetails.tsx

@@ -42,12 +42,10 @@ const Dashboard: React.FC = () => {
 
   const setUserAllowedToApprove = (userAllowedToApprove: boolean) => {
     isUserAllowedToApprove = userAllowedToApprove;
-    console.log('isUserAllowedToApprove:' + isUserAllowedToApprove);
   };
 
   const setUserAllowedToReject = (userAllowedToReject: boolean) => {
     isUserAllowedToReject = userAllowedToReject;
-    console.log({ isUserAllowedToReject });
   };
 
   useEffect(() => {

website/docs/configuration/reference.mdx

@@ -1931,4 +1931,4 @@ Specific value: `"jwt"`
 </details>
 
 ----------------------------------------------------------------------------------------------------------------------------
-Generated using [json-schema-for-humans](https://github.com/coveooss/json-schema-for-humans) on 2025-11-18 at 13:43:30 +0900
+Generated using [json-schema-for-humans](https://github.com/coveooss/json-schema-for-humans) on 2025-11-18 at 19:51:24 +0900