refactor(ts): refactor check processors to ts

Author: jescalada

src/proxy/processors/push-action/checkAuthorEmails.js renamed to src/proxy/processors/push-action/checkAuthorEmails.ts

@@ -1,9 +1,10 @@
-const Step = require('../../actions').Step;
-const config = require('../../../config');
+import { Action, Step } from '../../actions';
+import { getCommitConfig } from '../../../config';
+import { Commit } from '../../actions/Action';
 
-const commitConfig = config.getCommitConfig();
+const commitConfig = getCommitConfig();
 
-function isEmailAllowed(email) {
+const isEmailAllowed = (email: string): boolean => {
   const [emailLocal, emailDomain] = email.split('@');
   console.log({ emailLocal, emailDomain });
 
@@ -28,13 +29,12 @@ function isEmailAllowed(email) {
   return true;
 }
 
-// Execute if the repo is approved
-const exec = async (req, action) => {
+const exec = async (req: any, action: Action): Promise<Action> => {
   console.log({ req, action });
 
   const step = new Step('checkAuthorEmails');
 
-  const uniqueAuthorEmails = [...new Set(action.commitData.map((commit) => commit.authorEmail))];
+  const uniqueAuthorEmails = [...new Set(action.commitData?.map((commit: Commit) => commit.authorEmail))];
   console.log({ uniqueAuthorEmails });
 
   const illegalEmails = uniqueAuthorEmails.filter((email) => !isEmailAllowed(email));
@@ -62,4 +62,5 @@ const exec = async (req, action) => {
 };
 
 exec.displayName = 'checkAuthorEmails.exec';
-exports.exec = exec;
+
+export { exec };

src/proxy/processors/push-action/checkCommitMessages.js renamed to src/proxy/processors/push-action/checkCommitMessages.ts

@@ -1,9 +1,9 @@
-const Step = require('../../actions').Step;
-const config = require('../../../config');
+import { Action, Step } from '../../actions';
+import { getCommitConfig } from '../../../config';
 
-const commitConfig = config.getCommitConfig();
+const commitConfig = getCommitConfig();
 
-function isMessageAllowed(commitMessage) {
+const isMessageAllowed = (commitMessage: string): boolean => {
   console.log(`isMessageAllowed(${commitMessage})`);
 
   // Commit message is empty, i.e. '', null or undefined
@@ -19,18 +19,18 @@ function isMessageAllowed(commitMessage) {
   }
 
   // Configured blocked literals
-  const blockedLiterals = commitConfig.message.block.literals;
+  const blockedLiterals: string[] = commitConfig.message.block.literals;
 
   // Configured blocked patterns
-  const blockedPatterns = commitConfig.message.block.patterns;
+  const blockedPatterns: string[] = commitConfig.message.block.patterns;
 
   // Find all instances of blocked literals in commit message...
-  const positiveLiterals = blockedLiterals.map((literal) =>
+  const positiveLiterals = blockedLiterals.map((literal: string) =>
     commitMessage.toLowerCase().includes(literal.toLowerCase()),
   );
 
   // Find all instances of blocked patterns in commit message...
-  const positivePatterns = blockedPatterns.map((pattern) =>
+  const positivePatterns = blockedPatterns.map((pattern: string) =>
     commitMessage.match(new RegExp(pattern, 'gi')),
   );
 
@@ -50,12 +50,12 @@ function isMessageAllowed(commitMessage) {
 }
 
 // Execute if the repo is approved
-const exec = async (req, action) => {
+const exec = async (req: any, action: Action): Promise<Action> => {
   console.log({ req, action });
 
   const step = new Step('checkCommitMessages');
 
-  const uniqueCommitMessages = [...new Set(action.commitData.map((commit) => commit.message))];
+  const uniqueCommitMessages = [...new Set(action.commitData?.map((commit) => commit.message))];
   console.log({ uniqueCommitMessages });
 
   const illegalMessages = uniqueCommitMessages.filter((message) => !isMessageAllowed(message));
@@ -83,4 +83,5 @@ const exec = async (req, action) => {
 };
 
 exec.displayName = 'checkCommitMessages.exec';
-exports.exec = exec;
+
+export { exec };

src/proxy/processors/push-action/checkIfWaitingAuth.js renamed to src/proxy/processors/push-action/checkIfWaitingAuth.ts

@@ -1,11 +1,11 @@
-const Step = require('../../actions').Step;
-const data = require('../../../db');
+import { Action, Step } from '../../actions';
+import { getPush } from '../../../db';
 
 // Execute function
-const exec = async (req, action) => {
+const exec = async (req: any, action: Action): Promise<Action> => {
   const step = new Step('checkIfWaitingAuth');
   try {
-    const existingAction = await data.getPush(action.id);
+    const existingAction = await getPush(action.id);
     if (existingAction) {
       if (!action.error) {
         if (existingAction.authorised) {
@@ -14,7 +14,7 @@ const exec = async (req, action) => {
         }
       }
     }
-  } catch (e) {
+  } catch (e: any) {
     step.setError(e.toString('utf-8'));
     throw e;
   } finally {
@@ -24,4 +24,5 @@ const exec = async (req, action) => {
 };
 
 exec.displayName = 'checkIfWaitingAuth.exec';
-exports.exec = exec;
+
+export { exec };

src/proxy/processors/push-action/checkRepoInAuthorisedList.js renamed to src/proxy/processors/push-action/checkRepoInAuthorisedList.ts

@@ -1,14 +1,19 @@
-const Step = require('../../actions').Step;
-const db = require('../../../db');
+import { Action, Step } from '../../actions';
+import { getRepos } from '../../../db';
+import { Repo } from '../../../db/types';
 
 // Execute if the repo is approved
-const exec = async (req, action, authorisedList = db.getRepos) => {
+const exec = async (
+  req: any,
+  action: Action,
+  authorisedList: () => Promise<Repo[]> = getRepos,
+): Promise<Action> => {
   const step = new Step('checkRepoInAuthorisedList');
 
   const list = await authorisedList();
   console.log(list);
 
-  const found = list.find((x) => {
+  const found = list.find((x: Repo) => {
     const targetName = action.repo.replace('.git', '').toLowerCase();
     const allowedName = `${x.project}/${x.name}`.replace('.git', '').toLowerCase();
     console.log(`${targetName} = ${allowedName}`);
@@ -34,4 +39,5 @@ const exec = async (req, action, authorisedList = db.getRepos) => {
 };
 
 exec.displayName = 'checkRepoInAuthorisedList.exec';
-exports.exec = exec;
+
+export { exec };

src/proxy/processors/push-action/checkUserPushPermission.js renamed to src/proxy/processors/push-action/checkUserPushPermission.ts

@@ -1,22 +1,22 @@
-const Step = require('../../actions').Step;
-const db = require('../../../db');
+import { Action, Step } from '../../actions';
+import { getUsers, isUserPushAllowed } from '../../../db';
 
 // Execute if the repo is approved
-const exec = async (req, action) => {
+const exec = async (req: any, action: Action): Promise<Action> => {
   const step = new Step('checkUserPushPermission');
 
   const repoName = action.repo.split('/')[1].replace('.git', '');
   let isUserAllowed = false;
   let user = action.user;
 
   // Find the user associated with this Git Account
-  const list = await db.getUsers({ gitAccount: action.user });
+  const list = await getUsers({ gitAccount: action.user });
 
   console.log(JSON.stringify(list));
 
   if (list.length == 1) {
     user = list[0].username;
-    isUserAllowed = await db.isUserPushAllowed(repoName, user);
+    isUserAllowed = await isUserPushAllowed(repoName, user);
   }
 
   console.log(`User ${user} permission on Repo ${repoName} : ${isUserAllowed}`);
@@ -30,8 +30,8 @@ const exec = async (req, action) => {
 
     step.setError(
       `Rejecting push as user ${action.user} ` +
-        `is not allowed to push on repo ` +
-        `${action.repo}`,
+      `is not allowed to push on repo ` +
+      `${action.repo}`,
     );
     action.addStep(step);
     return action;
@@ -43,4 +43,5 @@ const exec = async (req, action) => {
 };
 
 exec.displayName = 'checkUserPushPermission.exec';
-exports.exec = exec;
+
+export { exec };