fix: user.admin errors and failing e2e tests

Author: jescalada

src/ui/components/Navbars/DashboardNavbarLinks.tsx

@@ -28,7 +28,7 @@ const DashboardNavbarLinks: React.FC = () => {
   const [openProfile, setOpenProfile] = useState<HTMLElement | null>(null);
   const [, setAuth] = useState<boolean>(true);
   const [, setIsLoading] = useState<boolean>(true);
-  const [errorMessage, setErrorMessage] = useState<string>('');
+  const [, setErrorMessage] = useState<string>('');
   const [user, setUser] = useState<PublicUser | null>(null);
 
   useEffect(() => {
@@ -67,7 +67,6 @@ const DashboardNavbarLinks: React.FC = () => {
 
   return (
     <div>
-      {errorMessage && <div className={classes.errorMessage}>{errorMessage}</div>}
       <div className={classes.manager}>
         <Button
           color={window.innerWidth > 959 ? 'transparent' : 'white'}

src/ui/views/RepoDetails/RepoDetails.tsx

@@ -101,7 +101,7 @@ const RepoDetails: React.FC = () => {
               justifyContent='flex-end'
               alignItems='center'
             >
-              {user.admin && (
+              {user?.admin && (
                 <Grid item>
                   <Button
                     variant='contained'
@@ -170,7 +170,7 @@ const RepoDetails: React.FC = () => {
                 <h3>
                   <Visibility /> Reviewers
                 </h3>
-                {user.admin && (
+                {user?.admin && (
                   <div style={{ textAlign: 'right' }}>
                     <AddUser repoId={repoId || ''} type='authorise' refreshFn={refresh} />
                   </div>
@@ -180,7 +180,7 @@ const RepoDetails: React.FC = () => {
                     <TableHead>
                       <TableRow>
                         <TableCell align='left'>Username</TableCell>
-                        {user.admin && <TableCell align='right'></TableCell>}
+                        {user?.admin && <TableCell align='right'></TableCell>}
                       </TableRow>
                     </TableHead>
                     <TableBody>
@@ -189,7 +189,7 @@ const RepoDetails: React.FC = () => {
                           <TableCell align='left'>
                             <UserLink username={username} />
                           </TableCell>
-                          {user.admin && (
+                          {user?.admin && (
                             <TableCell align='right' component='th' scope='row'>
                               <Button
                                 variant='contained'
@@ -213,7 +213,7 @@ const RepoDetails: React.FC = () => {
                 <h3>
                   <Code /> Contributors
                 </h3>
-                {user.admin && (
+                {user?.admin && (
                   <div style={{ textAlign: 'right' }}>
                     <AddUser repoId={repoId || ''} type='push' refreshFn={refresh} />
                   </div>
@@ -223,7 +223,7 @@ const RepoDetails: React.FC = () => {
                     <TableHead>
                       <TableRow>
                         <TableCell align='left'>Username</TableCell>
-                        {user.admin && <TableCell align='right'></TableCell>}
+                        {user?.admin && <TableCell align='right'></TableCell>}
                       </TableRow>
                     </TableHead>
                     <TableBody>
@@ -232,7 +232,7 @@ const RepoDetails: React.FC = () => {
                           <TableCell align='left'>
                             <UserLink username={username} />
                           </TableCell>
-                          {user.admin && (
+                          {user?.admin && (
                             <TableCell align='right' component='th' scope='row'>
                               <Button
                                 variant='contained'

src/ui/views/RepoList/Components/Repositories.tsx

@@ -117,7 +117,7 @@ export default function Repositories(): React.ReactElement {
   if (isLoading) return <div>Loading...</div>;
   if (isError) return <Danger>{errorMessage}</Danger>;
 
-  const addrepoButton = user.admin ? (
+  const addrepoButton = user?.admin ? (
     <GridItem>
       <NewRepo onSuccess={refresh} />
     </GridItem>

src/ui/views/User/UserProfile.tsx

@@ -139,7 +139,7 @@ export default function UserProfile(): React.ReactElement {
                 )}
                 <GridItem xs={2} sm={2} md={2}>
                   <FormLabel component='legend'>Administrator</FormLabel>
-                  {user.admin ? (
+                  {user?.admin ? (
                     <span style={{ color: 'green' }}>
                       <Check fontSize='small' />
                     </span>

src/ui/views/UserList/Components/UserList.tsx

@@ -91,7 +91,7 @@ const UserList: React.FC = () => {
                     </a>
                   </TableCell>
                   <TableCell align='left'>
-                    {user.admin ? (
+                    {user?.admin ? (
                       <Check fontSize='small' color='primary' />
                     ) : (
                       <CloseRounded color='error' />