fix(ts): add proper typing to chain module and fix minor issues

Author: jescalada

package.json

@@ -47,7 +47,6 @@
     "connect-mongo": "^5.1.0",
     "cors": "^2.8.5",
     "diff2html": "^3.4.33",
-    "eslint-plugin-typescript": "^0.14.0",
     "express": "^4.18.2",
     "express-http-proxy": "^2.0.0",
     "express-rate-limit": "^7.1.5",
@@ -101,6 +100,7 @@
     "eslint-plugin-prettier": "^5.0.0",
     "eslint-plugin-react": "^7.21.5",
     "eslint-plugin-standard": "^5.0.0",
+    "eslint-plugin-typescript": "^0.14.0",
     "husky": "^9.0.0",
     "mocha": "^10.8.2",
     "nyc": "^17.0.0",

src/proxy/chain.ts

@@ -2,7 +2,7 @@ import { PluginLoader } from '../plugin';
 import { Action } from './actions';
 import * as proc from './processors';
 
-const pushActionChain = [
+const pushActionChain: ((req: any, action: Action) => Promise<Action>)[] = [
   proc.push.parsePush,
   proc.push.checkRepoInAuthorisedList,
   proc.push.checkCommitMessages,
@@ -18,19 +18,17 @@ const pushActionChain = [
   proc.push.blockForAuth,
 ];
 
-const pullActionChain = [proc.push.checkRepoInAuthorisedList];
+const pullActionChain: ((req: any, action: Action) => Promise<Action>)[] = [proc.push.checkRepoInAuthorisedList];
 
 let pluginsInserted = false;
 
 export const executeChain = async (req: any, res: any): Promise<Action> => {
   let action: Action;
   try {
     action = await proc.pre.parseAction(req);
-    const actions = await getChain(action);
-    for (const i in actions) {
-      if (!i) continue;
-      const fn = actions[i as any];
+    const actionFns = await getChain(action);
 
+    for (const fn of actionFns) {
       action = await fn(req, action);
       if (!action.continue()) {
         return action;
@@ -53,7 +51,7 @@ export const executeChain = async (req: any, res: any): Promise<Action> => {
  */
 let chainPluginLoader: PluginLoader;
 
-const getChain = async (action: Action) => {
+const getChain = async (action: Action): Promise<((req: any, action: Action) => Promise<Action>)[]> => {
   if (chainPluginLoader === undefined) {
     console.error(
       'Plugin loader was not initialized! This is an application error. Please report it to the GitProxy maintainers. Skipping plugins...',
@@ -77,13 +75,9 @@ const getChain = async (action: Action) => {
     // This is set to true so that we don't re-insert the plugins into the chain
     pluginsInserted = true;
   }
-  if (action.type === 'pull') {
-    return pullActionChain;
-  }
-  if (action.type === 'push') {
-    return pushActionChain;
-  }
-  if (action.type === 'default') return [];
+  if (action.type === 'pull') return pullActionChain;
+  if (action.type === 'push') return pushActionChain;
+  return [];
 };
 
 export default {

src/proxy/processors/push-action/parsePush.ts

@@ -12,7 +12,7 @@ if (!fs.existsSync(dir)) {
   fs.mkdirSync(dir, { recursive: true });
 }
 
-const exec = async (req: any, action: Action): Promise<Action> => {
+async function exec(req: any, action: Action): Promise<Action> {
   const step = new Step('parsePackFile');
 
   try {