chore: remove unused reviewerGitAccount processing and fix getProxyUrl url processing

Author: jescalada

src/service/routes/push.ts

@@ -128,19 +128,6 @@ router.post('/:id/authorise', async (req: Request, res: Response) => {
     if (isAllowed) {
       console.log(`user ${username} approved push request for ${id}`);
 
-      const reviewerList = await db.getUsers({ username });
-      console.log({ reviewerList });
-
-      const reviewerGitAccount = reviewerList[0].gitAccount;
-      console.log({ reviewerGitAccount });
-
-      if (!reviewerGitAccount) {
-        res.status(401).send({
-          message: 'You must associate a GitHub account with your user before approving...',
-        });
-        return;
-      }
-
       const attestation = {
         questions,
         timestamp: new Date(),

src/service/urls.ts

@@ -6,17 +6,15 @@ import * as config from '../config';
 const { GIT_PROXY_SERVER_PORT: PROXY_HTTP_PORT, GIT_PROXY_UI_PORT: UI_PORT } = serverConfig;
 
 export const getProxyURL = (req: Request): string => {
-  const defaultURL = `${req.protocol}://${req.headers.host}`.replace(
-    `:${UI_PORT}`,
-    `:${PROXY_HTTP_PORT}`,
+  return (
+    config.getDomains().proxy ??
+    `${req.protocol}://${req.headers.host}`.replace(`:${UI_PORT}`, `:${PROXY_HTTP_PORT}`)
   );
-  return (config.getDomains().proxy as string) ?? defaultURL;
 };
 
 export const getServiceUIURL = (req: Request): string => {
-  const defaultURL = `${req.protocol}://${req.headers.host}`.replace(
-    `:${PROXY_HTTP_PORT}`,
-    `:${UI_PORT}`,
+  return (
+    config.getDomains().service ??
+    `${req.protocol}://${req.headers.host}`.replace(`:${PROXY_HTTP_PORT}`, `:${UI_PORT}`)
   );
-  return (config.getDomains().service as string) ?? defaultURL;
 };