test: add tests for checkhiddencommit

Author: fabiovincenzi

test/chain.test.js

@@ -23,6 +23,7 @@ const mockPushProcessors = {
   checkAuthorEmails: sinon.stub(),
   checkUserPushPermission: sinon.stub(),
   checkIfWaitingAuth: sinon.stub(),
+  checkHiddenCommits: sinon.stub(),
   pullRemote: sinon.stub(),
   writePack: sinon.stub(),
   preReceive: sinon.stub(),
@@ -39,6 +40,7 @@ mockPushProcessors.checkCommitMessages.displayName = 'checkCommitMessages';
 mockPushProcessors.checkAuthorEmails.displayName = 'checkAuthorEmails';
 mockPushProcessors.checkUserPushPermission.displayName = 'checkUserPushPermission';
 mockPushProcessors.checkIfWaitingAuth.displayName = 'checkIfWaitingAuth';
+mockPushProcessors.checkHiddenCommits.displayName = 'checkHiddenCommits';
 mockPushProcessors.pullRemote.displayName = 'pullRemote';
 mockPushProcessors.writePack.displayName = 'writePack';
 mockPushProcessors.preReceive.displayName = 'preReceive';
@@ -110,7 +112,9 @@ describe('proxy chain', function () {
     mockPushProcessors.checkCommitMessages.resolves(continuingAction);
     mockPushProcessors.checkAuthorEmails.resolves(continuingAction);
     mockPushProcessors.checkUserPushPermission.resolves(continuingAction);
-
+    mockPushProcessors.checkHiddenCommits.resolves(continuingAction);
+    mockPushProcessors.pullRemote.resolves(continuingAction);
+    mockPushProcessors.writePack.resolves(continuingAction);
     // this stops the chain from further execution
     mockPushProcessors.checkIfWaitingAuth.resolves({
       type: 'push',
@@ -126,7 +130,10 @@ describe('proxy chain', function () {
     expect(mockPushProcessors.checkAuthorEmails.called).to.be.true;
     expect(mockPushProcessors.checkUserPushPermission.called).to.be.true;
     expect(mockPushProcessors.checkIfWaitingAuth.called).to.be.true;
-    expect(mockPushProcessors.pullRemote.called).to.be.false;
+    expect(mockPushProcessors.pullRemote.called).to.be.true;
+    expect(mockPushProcessors.checkHiddenCommits.called).to.be.true;
+    expect(mockPushProcessors.writePack.called).to.be.true;
+    expect(mockPushProcessors.getMissingData.called).to.be.false;
     expect(mockPushProcessors.audit.called).to.be.true;
 
     expect(result.type).to.equal('push');
@@ -143,6 +150,9 @@ describe('proxy chain', function () {
     mockPushProcessors.checkCommitMessages.resolves(continuingAction);
     mockPushProcessors.checkAuthorEmails.resolves(continuingAction);
     mockPushProcessors.checkUserPushPermission.resolves(continuingAction);
+    mockPushProcessors.checkHiddenCommits.resolves(continuingAction);
+    mockPushProcessors.pullRemote.resolves(continuingAction);
+    mockPushProcessors.writePack.resolves(continuingAction);
     // this stops the chain from further execution
     mockPushProcessors.checkIfWaitingAuth.resolves({
       type: 'push',
@@ -158,7 +168,10 @@ describe('proxy chain', function () {
     expect(mockPushProcessors.checkAuthorEmails.called).to.be.true;
     expect(mockPushProcessors.checkUserPushPermission.called).to.be.true;
     expect(mockPushProcessors.checkIfWaitingAuth.called).to.be.true;
-    expect(mockPushProcessors.pullRemote.called).to.be.false;
+    expect(mockPushProcessors.pullRemote.called).to.be.true;
+    expect(mockPushProcessors.checkHiddenCommits.called).to.be.true;
+    expect(mockPushProcessors.writePack.called).to.be.true;
+    expect(mockPushProcessors.getMissingData.called).to.be.false;
     expect(mockPushProcessors.audit.called).to.be.true;
 
     expect(result.type).to.equal('push');
@@ -178,6 +191,7 @@ describe('proxy chain', function () {
     mockPushProcessors.checkIfWaitingAuth.resolves(continuingAction);
     mockPushProcessors.pullRemote.resolves(continuingAction);
     mockPushProcessors.writePack.resolves(continuingAction);
+    mockPushProcessors.checkHiddenCommits.resolves(continuingAction);
     mockPushProcessors.preReceive.resolves(continuingAction);
     mockPushProcessors.getDiff.resolves(continuingAction);
     mockPushProcessors.clearBareClone.resolves(continuingAction);
@@ -195,6 +209,7 @@ describe('proxy chain', function () {
     expect(mockPushProcessors.checkUserPushPermission.called).to.be.true;
     expect(mockPushProcessors.checkIfWaitingAuth.called).to.be.true;
     expect(mockPushProcessors.pullRemote.called).to.be.true;
+    expect(mockPushProcessors.checkHiddenCommits.called).to.be.true;
     expect(mockPushProcessors.writePack.called).to.be.true;
     expect(mockPushProcessors.preReceive.called).to.be.true;
     expect(mockPushProcessors.getDiff.called).to.be.true;
@@ -270,6 +285,7 @@ describe('proxy chain', function () {
     mockPushProcessors.checkIfWaitingAuth.resolves(action);
     mockPushProcessors.pullRemote.resolves(action);
     mockPushProcessors.writePack.resolves(action);
+    mockPushProcessors.checkHiddenCommits.resolves(action);
 
     mockPushProcessors.preReceive.resolves({
       ...action,
@@ -316,6 +332,7 @@ describe('proxy chain', function () {
     mockPushProcessors.checkIfWaitingAuth.resolves(action);
     mockPushProcessors.pullRemote.resolves(action);
     mockPushProcessors.writePack.resolves(action);
+    mockPushProcessors.checkHiddenCommits.resolves(action);
 
     mockPushProcessors.preReceive.resolves({
       ...action,
@@ -363,6 +380,7 @@ describe('proxy chain', function () {
     mockPushProcessors.checkIfWaitingAuth.resolves(action);
     mockPushProcessors.pullRemote.resolves(action);
     mockPushProcessors.writePack.resolves(action);
+    mockPushProcessors.checkHiddenCommits.resolves(action);
 
     mockPushProcessors.preReceive.resolves({
       ...action,
@@ -409,6 +427,7 @@ describe('proxy chain', function () {
     mockPushProcessors.checkIfWaitingAuth.resolves(action);
     mockPushProcessors.pullRemote.resolves(action);
     mockPushProcessors.writePack.resolves(action);
+    mockPushProcessors.checkHiddenCommits.resolves(action);
 
     mockPushProcessors.preReceive.resolves({
       ...action,

test/checkHiddenCommit.test.js

@@ -0,0 +1,95 @@
+// test/checkHiddenCommits.test.js
+const fs = require('fs');
+const childProcess = require('child_process');
+import * as sinon from 'sinon';
+const { expect } = require('chai');
+
+const { exec: checkHidden } = require('../src/proxy/processors/push-action/checkHiddenCommits');
+const { Action } = require('../src/proxy/actions');
+
+describe('checkHiddenCommits.exec', () => {
+  let action;
+  let sandbox;
+  let spawnSyncStub;
+  let readdirSyncStub;
+
+  beforeEach(() => {
+    sandbox = sinon.createSandbox();
+
+    // stub spawnSync and fs.readdirSync
+    spawnSyncStub = sandbox.stub(childProcess, 'spawnSync');
+    readdirSyncStub = sandbox.stub(fs, 'readdirSync');
+
+    // prepare a fresh Action
+    action = new Action('some-id', 'push', 'POST', Date.now(), 'repo.git');
+    action.proxyGitPath = '/fake';
+    action.commitFrom = '0000000000000000000000000000000000000000';
+    action.commitTo = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa';
+    action.newIdxFiles = ['pack-test.idx'];
+  });
+
+  afterEach(() => {
+    sandbox.restore();
+  });
+
+  it('reports all commits unreferenced and sets error=true', async () => {
+    // 1) rev-list → no introduced commits
+    // 2) verify-pack → two commits in pack
+    spawnSyncStub.onFirstCall().returns({ stdout: '' }).onSecondCall().returns({
+      stdout: 'deadbeef commit 100 1\ncafebabe commit 100 2\n',
+    });
+
+    readdirSyncStub.returns(['pack-test.idx']);
+
+    await checkHidden({ body: '' }, action);
+
+    const step = action.steps.find((s) => s.stepName === 'checkHiddenCommits');
+    expect(step.logs).to.include('checkHiddenCommits - ❌ Unreferenced commits: 2');
+    expect(action.error).to.be.true;
+  });
+
+  it('mixes referenced & unreferenced correctly', async () => {
+    // 1) git rev-list → introduces one commit “deadbeef”
+    // 2) git verify-pack → the pack contains two commits
+    spawnSyncStub.onFirstCall().returns({ stdout: 'deadbeef\n' }).onSecondCall().returns({
+      stdout: 'deadbeef commit 100 1\ncafebabe commit 100 2\n',
+    });
+
+    readdirSyncStub.returns(['pack-test.idx']);
+
+    await checkHidden({ body: '' }, action);
+
+    const step = action.steps.find((s) => s.stepName === 'checkHiddenCommits');
+    expect(step.logs).to.include('checkHiddenCommits - ✅ Referenced commits: 1');
+    expect(step.logs).to.include('checkHiddenCommits - ❌ Unreferenced commits: 1');
+    expect(action.error).to.be.true;
+  });
+
+  it.only('reports all commits referenced and sets error=false', async () => {
+    // 1) rev-list → introduces both commits
+    // 2) verify-pack → the pack contains the same two commits
+    spawnSyncStub.onFirstCall().returns({ stdout: 'deadbeef\ncafebabe\n' }).onSecondCall().returns({
+      stdout: 'deadbeef commit 100 1\ncafebabe commit 100 2\n',
+    });
+
+    readdirSyncStub.returns(['pack-test.idx']);
+
+    await checkHidden({ body: '' }, action);
+
+    const step = action.steps.find((s) => s.stepName === 'checkHiddenCommits');
+    expect(step.logs).to.include('checkHiddenCommits - ✅ Referenced commits: 2');
+    expect(step.logs).to.include('checkHiddenCommits - ❌ Unreferenced commits: 0');
+    expect(action.error).to.be.false;
+  });
+
+  it('throws if commitFrom or commitTo is missing', async () => {
+    delete action.commitFrom;
+
+    try {
+      await checkHidden({ body: '' }, action);
+      throw new Error('Expected checkHidden to throw');
+    } catch (err) {
+      expect(err.message).to.match(/Both action.commitFrom and action.commitTo must be defined/);
+    }
+  });
+});