feat: add auto rejection

Author: fabiovincenzi

src/proxy/actions/Action.js

@@ -15,6 +15,7 @@ class Action {
   canceled = false;
   rejected = false;
   autoApproved = false;
+  autoRejected = false;
   commitFrom;
   commitTo;
   branch;
@@ -108,10 +109,16 @@ class Action {
   /**
    *`
    */
-  setAllowAutoApprover() {
+  setAutoApproval() {
     this.autoApproved = true;
   }
 
+  /**
+   *`
+   */
+  setAutoRejection() {
+    this.autoRejected = true;
+  }
   /**
    * @return {bool}
    */

src/proxy/processors/push-action/preReceive.js

@@ -9,6 +9,7 @@ const sanitizeInput = (_req, action) => {
 
 const exec = async (req, action, hookFilePath = './hooks/pre-receive.sh') => {
   const step = new Step('executeExternalPreReceiveHook');
+  let stderrTrimmed = '';
 
   try {
     const resolvedPath = path.resolve(hookFilePath);
@@ -34,37 +35,33 @@ const exec = async (req, action, hookFilePath = './hooks/pre-receive.sh') => {
 
     const { stdout, stderr, status } = hookProcess;
 
-    const stderrTrimmed = stderr ? stderr.trim() : '';
+    stderrTrimmed = stderr ? stderr.trim() : '';
     const stdoutTrimmed = stdout ? stdout.trim() : '';
 
     step.log(`Hook exited with status ${status}`);
 
-    if (status === 1) {
-      step.log('Push requires manual approval.');
+    if (status === 0) {
+      step.log('Push automatically approved by pre-receive hook.');
       action.addStep(step);
-      return action;
-    } else if (status === 2) {
-      step.error = true;
-      step.log('Push rejected by pre-receive hook.');
-      step.log(`Hook stderr: ${stderrTrimmed}`);
-      step.setError(stdoutTrimmed || 'Pre-receive hook rejected the push.');
+      action.setAutoApproval();
+    } else if (status === 1) {
+      step.log('Push automatically rejected by pre-receive hook.');
       action.addStep(step);
-      return action;
-    } else if (status === 0) {
-      step.log('Push automatically approved by pre-receive hook.');
+      action.setAutoRejection();
+    } else if (status === 2) {
+      step.log('Push requires manual approval.');
       action.addStep(step);
-      action.setAllowAutoApprover();
-      return action;
     } else {
       step.error = true;
       step.log(`Unexpected hook status: ${status}`);
       step.setError(stdoutTrimmed || 'Unknown pre-receive hook error.');
       action.addStep(step);
-      return action;
     }
+    return action;
   } catch (error) {
     step.error = true;
-    step.setError(`Hook execution error: ${error.message}`);
+    step.log('Push failed, pre-receive hook returned an error.');
+    step.setError(`Hook execution error: ${stderrTrimmed || error.message}`);
     action.addStep(step);
     return action;
   }