feat(test): edit tests for preReceive in order to handle auto approval

Author: fabiovincenzi

test/chain.test.js

@@ -1,6 +1,7 @@
 const chai = require('chai');
 const sinon = require('sinon');
 const { PluginLoader } = require('../src/plugin');
+const db = require('../src/db');
 
 chai.should();
 const expect = chai.expect;
@@ -245,4 +246,52 @@ describe('proxy chain', function () {
     expect(mockPushProcessors.parsePush.called).to.be.false;
     expect(result).to.deep.equal(action);
   });
+
+  it('should approve push automatically and record in the database', async function () {
+    const req = {};
+    const action = {
+      type: 'push',
+      continue: () => true,
+      allowPush: false,
+      setAllowAutoApprover: sinon.stub(),
+      repoName: 'test-repo',
+      commitTo: 'newCommitHash',
+      autoApproved: false,
+    };
+
+    mockPreProcessors.parseAction.resolves(action);
+    mockPushProcessors.parsePush.resolves(action);
+    mockPushProcessors.checkRepoInAuthorisedList.resolves(action);
+    mockPushProcessors.checkCommitMessages.resolves(action);
+    mockPushProcessors.checkAuthorEmails.resolves(action);
+    mockPushProcessors.checkUserPushPermission.resolves(action);
+    mockPushProcessors.checkIfWaitingAuth.resolves(action);
+    mockPushProcessors.pullRemote.resolves(action);
+    mockPushProcessors.writePack.resolves(action);
+
+    mockPushProcessors.preReceive.resolves({
+      ...action,
+      steps: [{ error: false, logs: ['Push automatically approved by pre-receive hook.'] }],
+      allowPush: true,
+      autoApproved: true,
+    });
+
+    mockPushProcessors.getDiff.resolves(action);
+    mockPushProcessors.clearBareClone.resolves(action);
+    mockPushProcessors.scanDiff.resolves(action);
+    mockPushProcessors.blockForAuth.resolves(action);
+
+    const dbStub = sinon.stub(db, 'authorise').resolves(true);
+
+    const result = await chain.executeChain(req);
+
+    expect(result.type).to.equal('push');
+    expect(result.allowPush).to.be.true;
+    expect(result.continue).to.be.a('function');
+
+    expect(dbStub.calledOnce).to.be.true;
+    expect(dbStub.calledWith(action.id, sinon.match({ autoApproved: true }))).to.be.true;
+
+    dbStub.restore();
+  });
 });

test/preReceive/pre-receive-hooks/always-exit-1.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+while read oldrev newrev refname; do
+  echo "Push need manual approve to $refname"
+done
+exit 1

test/preReceive/pre-receive-hooks/always-reject.sh

@@ -2,4 +2,4 @@
 while read oldrev newrev refname; do
   echo "Push rejected to $refname"
 done
-exit 1
+exit 2

test/preReceive/preReceive.test.js

@@ -19,23 +19,24 @@ describe('Pre-Receive Hook Execution', function () {
       addStep: function (step) {
         this.steps.push(step);
       },
+      setAllowAutoApprover: sinon.stub(),
     };
   });
 
   afterEach(() => {
     sinon.restore();
   });
 
-  it('should execute hook successfully', async () => {
-    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-allow.sh');
+  it('should execute hook successfully and require manual approval', async () => {
+    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-exit-1.sh');
 
     const result = await exec(req, action, scriptPath);
 
     expect(result.steps).to.have.lengthOf(1);
     expect(result.steps[0].error).to.be.false;
-    expect(
-      result.steps[0].logs.some((log) => log.includes('Pre-receive hook executed successfully')),
-    ).to.be.true;
+    expect(result.steps[0].logs.some((log) => log.includes('Push requires manual approval.'))).to.be
+      .true;
+    expect(action.setAllowAutoApprover.called).to.be.false;
   });
 
   it('should skip execution when hook file does not exist', async () => {
@@ -50,6 +51,7 @@ describe('Pre-Receive Hook Execution', function () {
         log.includes('Pre-receive hook not found, skipping execution.'),
       ),
     ).to.be.true;
+    expect(action.setAllowAutoApprover.called).to.be.false;
   });
 
   it('should skip execution when hook directory does not exist', async () => {
@@ -64,6 +66,7 @@ describe('Pre-Receive Hook Execution', function () {
         log.includes('Pre-receive hook not found, skipping execution.'),
       ),
     ).to.be.true;
+    expect(action.setAllowAutoApprover.called).to.be.false;
   });
 
   it('should fail when hook execution returns an error', async () => {
@@ -76,11 +79,13 @@ describe('Pre-Receive Hook Execution', function () {
     const step = result.steps[0];
 
     expect(step.error).to.be.true;
+    expect(step.logs.some((log) => log.includes('Push rejected by pre-receive hook.'))).to.be.true;
     expect(step.logs.some((log) => log.includes('Hook stderr:'))).to.be.true;
 
     expect(step.errorMessage).to.exist;
 
     expect(action.steps).to.deep.include(step);
+    expect(action.setAllowAutoApprover.called).to.be.false;
   });
 
   it('should catch and handle unexpected errors', async () => {
@@ -95,5 +100,21 @@ describe('Pre-Receive Hook Execution', function () {
     expect(
       result.steps[0].logs.some((log) => log.includes('Hook execution error: Unexpected FS error')),
     ).to.be.true;
+    expect(action.setAllowAutoApprover.called).to.be.false;
+  });
+
+  it('should approve push automatically when hook returns status 0', async () => {
+    const scriptPath = path.resolve(__dirname, 'pre-receive-hooks/always-allow.sh');
+
+    const result = await exec(req, action, scriptPath);
+
+    expect(result.steps).to.have.lengthOf(1);
+    expect(result.steps[0].error).to.be.false;
+    expect(
+      result.steps[0].logs.some((log) =>
+        log.includes('Push automatically approved by pre-receive hook.'),
+      ),
+    ).to.be.true;
+    expect(action.setAllowAutoApprover.calledOnce).to.be.true;
   });
 });