fix: fix linter and test issues

Author: jescalada

package.json

@@ -62,7 +62,7 @@
     "moment": "^2.29.4",
     "mongodb": "^5.0.0",
     "nodemailer": "^6.6.1",
-    "openid-client": "^6.3.1",
+    "openid-client": "^6.4.2",
     "parse-diff": "^0.11.1",
     "passport": "^0.7.0",
     "passport-activedirectory": "^1.0.4",

src/service/passport/jwtAuthHandler.js

@@ -3,7 +3,7 @@ const { assignRoles, validateJwt } = require('./jwtUtils');
 /**
  * Middleware function to handle JWT authentication.
  * @param {*} overrideConfig optional configuration to override the default JWT configuration (e.g. for testing)
- * @returns {Function} the middleware function 
+ * @return {Function} the middleware function 
  */
 const jwtAuthHandler = (overrideConfig = null) => {
   return async (req, res, next) => {

src/service/passport/oidc.js

@@ -3,9 +3,6 @@ const db = require('../../db');
 let type;
 
 const configure = async (passport) => {
-  const openIdClient = await import('openid-client');
-  const { Strategy } = await import('openid-client/passport');
-  
   const authMethods = require('../../config').getAuthMethods();
   const oidcConfig = authMethods.find((method) => method.type.toLowerCase() === "openidconnect")?.oidcConfig;
   const { issuer, clientID, clientSecret, callbackURL, scope } = oidcConfig;
@@ -15,6 +12,8 @@ const configure = async (passport) => {
   }
 
   const server = new URL(issuer);
+  const openIdClient = await import('openid-client');
+  const { Strategy } = await import('openid-client/passport');
 
   try {
     const config = await openIdClient.discovery(server, clientID, clientSecret);

test/testJwtAuthHandler.test.js

@@ -33,7 +33,10 @@ describe('getJwks', () => {
 });
 
 describe('validateJwt', () => {
-  let decodeStub, verifyStub, pemStub, getJwksStub;
+  let decodeStub;
+  let verifyStub;
+  let pemStub;
+  let getJwksStub;
 
   beforeEach(() => {
     const jwksResponse = { keys: [{ kid: 'test-key', kty: 'RSA', n: 'abc', e: 'AQAB' }] };
@@ -112,7 +115,11 @@ describe('assignRoles', () => {
 });
 
 describe('jwtAuthHandler', () => {
-  let req, res, next, jwtConfig, validVerifyResponse;
+  let req;
+  let res;
+  let next;
+  let jwtConfig;
+  let validVerifyResponse;
 
   beforeEach(() => {
     req = { header: sinon.stub(), isAuthenticated: sinon.stub(), user: {} };