Remove usages of `trimTrailingDotGit`

[jescalada]

Is your feature request related to a problem? Please describe.
@andypols has suggested in #1110 that forcing the correct form of URL is cleaner than reusing the trimTrailingDotGit helper.

I've removed the .replace('.git', '')in getRepoByUrl. I have a new PR that forces the correct form of URL so the problem should go away.

It's all a bit nasty having to use functions like trimTrailingDotGit to adjust the urls. The urls in the proxy actions are always the .git kind. We should be able to match on the actual url and remove trimTrailingDotGit. We can do this incrementally and keep the PRs small.

Describe the solution you'd like
Remove the usages of trimTrailingDotGit while keeping functionality correct/intuitive

Describe alternatives you've considered
None, open to discussion

Additional context
Related PRs: #1109, #1110

Pinging @06kellyjac who contributed the helper file!

[kriswest]

#1043 removes most of the uses of this util function (but not all - there's still a usage in the UI, but nothing critical).
#1043 also introduces validation, in the UI, that URL is the .git version. See src/ui/views/RepoList/Components/NewRepo.tsx:

git-proxy/src/ui/views/RepoList/Components/NewRepo.tsx

Lines 87 to 96 in 8105796

	try {
	const parsedUrl = new URL(data.url);
	if (!parsedUrl.pathname.endsWith('.git')) {
	setError('Invalid git URL - Git URLs should end with .git');
	return;
	}
	} catch {
	setError('Invalid URL format');
	return;
	}

That validation should probably also exist in the API function for adding a repo:

git-proxy/src/service/routes/repo.js

Line 143 in 8105796

router.post('/', async (req, res) => {

it doesn't currently, but I can add it there to close this out...

All that being said, the docs for the Git protocols don't clearly state that a path ending in .git is required. In fact they suggest that GitHub allows you to use either:

In fact, for services like GitHub, the URL you use to view the repository online (for example, https://github.com/schacon/simplegit) is the same URL you can use to clone and, if you have access, push over.

Which I can confirm is actually the case for both GitHub and GitLab (the one difference being that Gitlab tells you through the git client that it is redirecting)... You can view the repo through the website with:
https://github.com/finos/git-proxy.git
and you can clone with
git clone https://github.com/finos/git-proxy

With github redirecting you as needed.

Knowing that .git is not required on either of the two main SCM services and isn't required in teh protocol, I think we need to take the validation OUT of #1043, because requiring the .get could block other SCM services or naked git servers . If we're going to validate the URL we probably need to do so with a git client, and apparently we DO NOT really need to clean up the URLs at all as all examples we have redirect as and when needed...

We could hint in the UI with a placeholder to try and ensure consistency, but it otherwise seems irrelevant to me now.

@jescalada @06kellyjac @andypols