-
Notifications
You must be signed in to change notification settings - Fork 141
Open
Description
Describe the bug
I note that since #1164 all proxied requests are being logged in the pushes table. However, I also note that:
- both fetch and pull requests appear to be POST requests and get classified as "default" - where parseAction seems to expect a GET request:
if (pathBreakdown.gitPath.endsWith('git-upload-pack') && req.method === 'GET') { - We don't store the request URL correctly (
url
field appears to be a duplicate of therepo
field, giving the remote repo URL) making it hard to determine what the original request was!
Misclassification will mean that the wrong action chain is applied. These are currently the same pull and default, but they might not be when plugins are in use or in future if we develop more processors to apply on pull.
To Reproduce
Steps to reproduce the behavior:
- Observe content of DB (or DB file)
- Perform a fetch and a pull through the proxy
- Investigate the content of the DB records created in the pull table, pay attention to the
type
,url
andrepo
values..
Expected behavior
Pulls are classified correctly and sufficient detail on each request is recorded to determine what git call it was after-the-fact. Investigate why the url
field is being populated with the repository url (which is in the repo
field already.
Metadata
Metadata
Assignees
Labels
No labels