refactor: refactor git-proxy-cli to TS + ESM
#1065
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jescalada
changed the title
cli to TS + ESMgit-proxy-cli to TS + ESM
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 76.91% 78.20% +1.28%
==========================================
Files 55 55
Lines 2270 2335 +65
Branches 255 363 +108
==========================================
+ Hits 1746 1826 +80
+ Misses 494 457 -37
- Partials 30 52 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
42 tasks
|
Closing this as merge conflicts got out of hand. Opened #1180 with CLI-specific changes instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064.
Based on #1063.
Would love some input from folks that use the CLI! I want to make sure that everything still works as expected, particularly the
buildscript wiring (builds into/git-proxy-cli/dist/*) and the execution from the main project.