fix: prevent DOS when checking an unknown repo #1095
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
jescalada
approved these changes
Jul 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 82.78% 82.78%
=======================================
Files 66 66
Lines 2783 2783
Branches 332 332
=======================================
Hits 2304 2304
Misses 431 431
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Kris West <[email protected]> Signed-off-by: Andy Pols <[email protected]>
|
@andypols you should be able to update this now against main. Please check its not re-introducing any functions that are not needed - we've done some consolidation of the duplicated code in the DB. |
kriswest
requested changes
Aug 21, 2025
|
@finos/git-proxy-maintainers I've merged with latest changes and all is left following @kriswest checking is the test. Please can you review and merge is all ok. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a potential denial-of-service (DoS) vulnerability:
When pushing to an unknown repository, the MongoDB implementation throws a TypeError due to attempting to access properties on a null object:
Root Cause
The file-based database implementation correctly checks for the existence of a repository before accessing its fields. However, the MongoDB implementation does not.
Specifically,
checkUserPushPermissioncallsisUserPushAllowed, which assumes the repository exists. If the repository is not found, accessing its properties throws a TypeError and stops the service.Fix
This PR addresses the issue by:
Adding a guard clause in the MongoDB implementation of
isUserPushAllowedto handle missing repositories safely.Adds a unit test to verify behaviour when the repository does not exist.