Hash ids for modular distributed compiled mode metadata (#1203)

* Use base 32 encoding for distributed metadata id hashing

* Hash ids for modular distributed metadata

Author: kevin-m-knight-gs

legend-pure-runtime/legend-pure-runtime-java-engine-compiled/src/main/java/org/finos/legend/pure/runtime/java/compiled/serialization/binary/DistributedBinaryGraphDeserializer.java

@@ -468,6 +468,12 @@ public RichIterable<String> getClassifierInstanceIds(String classifierId)
             return (classifierIndex == null) ? Lists.immutable.empty() : classifierIndex.getInstanceIds();
         }
 
+        @Override
+        public String processId(String id)
+        {
+            return (this.metadataName == null) ? id : super.processId(id);
+        }
+
         @Override
         public String processEnumId(String enumerationName, String enumName)
         {

legend-pure-runtime/legend-pure-runtime-java-engine-compiled/src/main/java/org/finos/legend/pure/runtime/java/compiled/serialization/binary/DistributedBinaryGraphSerializer.java

@@ -54,7 +54,7 @@ protected DistributedBinaryGraphSerializer(PureRuntime runtime, DistributedMetad
         this.metadataSpecification = metadataSpecification;
         this.runtime = runtime;
         this.processorSupport = runtime.getProcessorSupport();
-        this.idBuilder = DistributedMetadataHelper.possiblyHashIds(newIdBuilder(this.metadataSpecification, this.processorSupport));
+        this.idBuilder = newPossiblyHashedIdBuilder(this.metadataSpecification, this.processorSupport);
         this.classifierCaches = new GraphSerializer.ClassifierCaches(this.processorSupport);
     }
 
@@ -302,6 +302,12 @@ private static IdBuilder newIdBuilder_internal(String metadataName, ProcessorSup
                 .build();
     }
 
+    private static IdBuilder newPossiblyHashedIdBuilder(DistributedMetadataSpecification metadataSpec, ProcessorSupport processorSupport)
+    {
+        IdBuilder idBuilder = newIdBuilder(metadataSpec, processorSupport);
+        return (metadataSpec == null) ? idBuilder : DistributedMetadataHelper.possiblyHashIds(idBuilder);
+    }
+
     protected class SerializationCollector
     {
         private final MutableMap<String, MutableList<CoreInstance>> instancesForSerialization = Maps.mutable.empty();

legend-pure-runtime/legend-pure-runtime-java-engine-compiled/src/main/java/org/finos/legend/pure/runtime/java/compiled/serialization/binary/DistributedMetadataHelper.java

@@ -18,13 +18,11 @@
 import org.finos.legend.pure.m4.coreinstance.CoreInstance;
 import org.finos.legend.pure.runtime.java.compiled.generation.processors.IdBuilder;
 
-import java.nio.ByteBuffer;
-import java.util.Base64;
 import java.util.Objects;
 
 public class DistributedMetadataHelper
 {
-    private static final boolean HASH_IDS = Boolean.parseBoolean(System.getProperty("legend.pure.runtime.java.compiled.serialization.binary.distributed.hashids", "false"));
+    private static final boolean HASH_IDS = Boolean.parseBoolean(System.getProperty("legend.pure.runtime.java.compiled.serialization.binary.distributed.hashids", "true"));
 
     private static final String META_DATA_DIRNAME = "metadata/";
     private static final String SPECS_DIRNAME = META_DATA_DIRNAME + "specs/";
@@ -209,10 +207,8 @@ public static String hashId(String id)
             hash = SpreadFunctions.longSpreadOne(hash) + (codePoint = id.codePointAt(i));
         }
 
-        // convert to base64 string
-        byte[] bytes = new byte[8];
-        ByteBuffer.wrap(bytes).putLong(hash);
-        return Base64.getUrlEncoder().withoutPadding().encodeToString(bytes);
+        // convert to base 32 string
+        return Long.toUnsignedString(hash, 32);
     }
 
     public static IdBuilder hashIds(IdBuilder idBuilder)

legend-pure-runtime/legend-pure-runtime-java-engine-compiled/src/test/java/org/finos/legend/pure/runtime/java/compiled/runtime/serialization/binary/TestDistributedBinaryGraphSerialization.java

@@ -78,7 +78,7 @@ public void testModularSerialization() throws IOException
         PureRuntime runtime = buildRuntime(repo);
 
         DistributedBinaryGraphSerializer.newSerializer(runtime, repo).serialize(getFileWriter());
-        ListIterable<Obj> expectedObjs = getExpectedObjsFromRuntime(runtime, IdBuilder.builder(runtime.getProcessorSupport()).withDefaultIdPrefix(DistributedMetadataHelper.getMetadataIdPrefix(repo)).build());
+        ListIterable<Obj> expectedObjs = getExpectedObjsFromRuntime(runtime, DistributedMetadataHelper.possiblyHashIds(IdBuilder.builder(runtime.getProcessorSupport()).withDefaultIdPrefix(DistributedMetadataHelper.getMetadataIdPrefix(repo)).build()));
         testSerialization(expectedObjs, Lists.immutable.with(repo), false);
     }