Merge pull request #767 from finsweet/fix-race-conditions-init

fix: race conditions when initializing multiple scripts

Author: alexiglesias93

.changeset/curly-bikes-wait.md

@@ -0,0 +1,5 @@
+---
+'@finsweet/attributes': patch
+---
+
+fix: race conditions when initializing multiple scripts

packages/attributes/src/attributes.ts

@@ -29,13 +29,10 @@ const init = () => {
   // Collect pre-existing callbacks
   const callbacks = Array.isArray(FinsweetAttributes) ? (FinsweetAttributes as FinsweetAttributesCallback[]) : [];
 
-  // Collect library scripts
-  const scripts = [...document.querySelectorAll<HTMLScriptElement>(`script[type="module"][src="${import.meta.url}"]`)];
-
   // Init Attributes object
   window.FinsweetAttributes = {
     version,
-    scripts,
+    scripts: [],
     modules: {},
     process: new Set<FinsweetAttributeKey>(),
     utils: {
@@ -72,7 +69,13 @@ const init = () => {
 const initAttributes = () => {
   let autoLoad = false;
 
-  for (const script of window.FinsweetAttributes.scripts) {
+  const scripts = document.querySelectorAll<HTMLScriptElement>(`script[type="module"][src="${import.meta.url}"]`);
+
+  for (const script of scripts) {
+    if (window.FinsweetAttributes.scripts.includes(script)) continue;
+
+    window.FinsweetAttributes.scripts.push(script);
+
     autoLoad ||= script.getAttribute(`${ATTRIBUTES_ATTRIBUTE_PREFIX}-auto`) === 'true';
 
     for (const key of ATTRIBUTE_KEYS) {