Skip to content

Commit 0b49163

Browse files
authored
Merge pull request #686 from SUPERCILEX/save-creds-npe
Fix getContext NPE in saveCredentialsOrFinish
2 parents 945ba1d + 2a615f6 commit 0b49163

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

auth/src/main/java/com/firebase/ui/auth/util/signincontainer/SaveSmartLock.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
package com.firebase.ui.auth.util.signincontainer;
1616

1717
import android.app.PendingIntent;
18+
import android.content.Context;
1819
import android.content.Intent;
1920
import android.content.IntentSender;
2021
import android.net.Uri;
@@ -49,6 +50,8 @@ public class SaveSmartLock extends SmartLockBase<Status> {
4950
private static final int RC_SAVE = 100;
5051
private static final int RC_UPDATE_SERVICE = 28;
5152

53+
private Context mAppContext;
54+
5255
private String mName;
5356
private String mEmail;
5457
private String mPassword;
@@ -77,6 +80,12 @@ public static SaveSmartLock getInstance(FragmentActivity activity, FlowParameter
7780
return result;
7881
}
7982

83+
@Override
84+
public void onAttach(Context context) {
85+
super.onAttach(context);
86+
mAppContext = context.getApplicationContext();
87+
}
88+
8089
@Override
8190
public void onConnected(Bundle bundle) {
8291
if (TextUtils.isEmpty(mEmail)) {
@@ -205,7 +214,7 @@ public void saveCredentialsOrFinish(FirebaseUser firebaseUser,
205214
mProfilePictureUri = firebaseUser.getPhotoUrl() != null ? firebaseUser.getPhotoUrl()
206215
.toString() : null;
207216

208-
mGoogleApiClient = new Builder(getContext().getApplicationContext())
217+
mGoogleApiClient = new Builder(mAppContext)
209218
.addConnectionCallbacks(this)
210219
.addOnConnectionFailedListener(this)
211220
.addApi(Auth.CREDENTIALS_API)

0 commit comments

Comments
 (0)