Skip to content

Commit 1106c29

Browse files
Aaron MandleGerrit Code Review
authored andcommitted
Merge "fix the terms of service url"
2 parents 6878efb + 50c3116 commit 1106c29

File tree

6 files changed

+17
-2
lines changed

6 files changed

+17
-2
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/credentials/ChooseAccountActivity.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,13 +132,15 @@ public void onComplete(@NonNull Task<AuthResult> task) {
132132
startActivityForResult(AuthMethodPickerActivity.createIntent(
133133
getApplicationContext(),
134134
mAppName,
135+
mTermsOfServiceUrl,
135136
mProviderParcels
136137
), RC_AUTH_METHOD_PICKER);
137138
}
138139
} else {
139140
startActivityForResult(AuthMethodPickerActivity.createIntent(
140141
getApplicationContext(),
141142
mAppName,
143+
mTermsOfServiceUrl,
142144
mProviderParcels
143145
), RC_AUTH_METHOD_PICKER);
144146
}
@@ -164,6 +166,7 @@ public void onFailure(@NonNull Exception ex) {
164166
startActivity(AuthMethodPickerActivity.createIntent(
165167
getApplicationContext(),
166168
mAppName,
169+
mTermsOfServiceUrl,
167170
mProviderParcels
168171
));
169172
finish(RESULT_OK, new Intent());
@@ -200,6 +203,7 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
200203
AuthMethodPickerActivity.createIntent(
201204
getApplicationContext(),
202205
mAppName,
206+
mTermsOfServiceUrl,
203207
mProviderParcels), RC_AUTH_METHOD_PICKER);
204208
} else if (resultCode == RESULT_FIRST_USER) {
205209
// TODO: (serikb) figure out flow
@@ -237,6 +241,7 @@ protected void redirectToIdpSignIn(
237241
nextIntent = AuthMethodPickerActivity.createIntent(
238242
this,
239243
mAppName,
244+
mTermsOfServiceUrl,
240245
providers
241246
);
242247
}

auth/src/main/java/com/firebase/ui/auth/ui/email/AcquireEmailActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ private void startEmailHandler(String email, List<String> providers) {
6262
Intent registerIntent = RegisterEmailActivity.createIntent(
6363
AcquireEmailActivity.this,
6464
email,
65+
mTermsOfServiceUrl,
6566
mAppName
6667
);
6768
startActivityForResult(registerIntent, RC_REGISTER_ACCOUNT);

auth/src/main/java/com/firebase/ui/auth/ui/email/EmailHintContainerActivity.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ protected void onCreate(Bundle savedInstanceState) {
4949
e.printStackTrace();
5050
}
5151
}
52-
finish(BaseActivity.RESULT_CANCELED, new Intent());
52+
finish(RESULT_CANCELED, new Intent());
5353
return;
5454
}
5555

@@ -65,6 +65,7 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
6565
this,
6666
null,
6767
mAppName,
68+
mTermsOfServiceUrl,
6869
mProviderParcels
6970
),
7071
RC_SIGN_IN);
@@ -78,9 +79,11 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
7879
public static Intent getInitIntent(
7980
Context context,
8081
String appName,
82+
String tosUrl,
8183
ArrayList<IDPProviderParcel> providers) {
8284
return new Intent(context, EmailHintContainerActivity.class)
8385
.putExtra(ControllerConstants.EXTRA_APP_NAME, appName)
86+
.putExtra(ControllerConstants.EXTRA_TERMS_OF_SERVICE_URL, tosUrl)
8487
.putExtra(ControllerConstants.EXTRA_PROVIDERS, providers);
8588
}
8689
}

auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,11 @@ protected void onCreate(Bundle savedInstanceState) {
102102
public static Intent createIntent(
103103
Context context,
104104
String email,
105+
String tosUrl,
105106
String appName) {
106107
return new Intent(context, RegisterEmailActivity.class)
107108
.putExtra(ControllerConstants.EXTRA_APP_NAME, appName)
109+
.putExtra(ControllerConstants.EXTRA_TERMS_OF_SERVICE_URL, tosUrl)
108110
.putExtra(ControllerConstants.EXTRA_EMAIL, email);
109111
}
110112

auth/src/main/java/com/firebase/ui/auth/ui/email/SignInNoPasswordActivity.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,13 @@ public static Intent createIntent(
5959
Context context,
6060
String email,
6161
String appName,
62+
String tosUrl,
6263
ArrayList<IDPProviderParcel> providers
6364
) {
6465
return new Intent(context, SignInNoPasswordActivity.class)
6566
.putExtra(ControllerConstants.EXTRA_EMAIL, email)
6667
.putExtra(ControllerConstants.EXTRA_APP_NAME, appName)
68+
.putExtra(ControllerConstants.EXTRA_TERMS_OF_SERVICE_URL, tosUrl)
6769
.putExtra(ControllerConstants.EXTRA_PROVIDERS, providers);
6870
}
6971

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ public void onClick(View view) {
160160
Intent intent = EmailHintContainerActivity.getInitIntent(
161161
this,
162162
mAppName,
163+
mTermsOfServiceUrl,
163164
mProviderParcels
164165
);
165166
startActivityForResult(intent, RC_EMAIL_FLOW);
@@ -174,10 +175,11 @@ public void onClick(View view) {
174175
* @return The intent to start the authentication picker activity.
175176
*/
176177
public static Intent createIntent(
177-
Context context, String appName, ArrayList<IDPProviderParcel> parcels) {
178+
Context context, String appName, String tosUrl, ArrayList<IDPProviderParcel> parcels) {
178179
return new Intent()
179180
.setClass(context, AuthMethodPickerActivity.class)
180181
.putExtra(ControllerConstants.EXTRA_APP_NAME, appName)
182+
.putExtra(ControllerConstants.EXTRA_TERMS_OF_SERVICE_URL, tosUrl)
181183
.putParcelableArrayListExtra(ControllerConstants.EXTRA_PROVIDERS, parcels);
182184
}
183185
}

0 commit comments

Comments
 (0)