Review comments and lint checks

samtstern · samtstern · commit 1184b9177942 · 2016-12-08T08:34:28.000-08:00
Change-Id: I5fecad0d92466b727eea47b0ec03da876652b143
diff --git a/.travis.yml b/.travis.yml
@@ -32,24 +32,3 @@ after_failure:
   - cat app/build/reports/lint-results.html
   - cat app/build/reports/findbugs.html
   - cat app/build/reports/pmd.html
-
-  # auth
-  - cat auth/build/reports/checkstyle.html
-  - cat auth/build/reports/lint-results.xml
-  - cat auth/build/reports/lint-results.html
-  - cat auth/build/reports/findbugs.html
-  - cat auth/build/reports/pmd.html
-
-  # database
-  - cat database/build/reports/checkstyle.html
-  - cat database/build/reports/lint-results.xml
-  - cat database/build/reports/lint-results.html
-  - cat database/build/reports/findbugs.html
-  - cat database/build/reports/pmd.html
-
-  # storage
-  - cat storage/build/reports/checkstyle.html
-  - cat storage/build/reports/lint-results.xml
-  - cat storage/build/reports/lint-results.html
-  - cat storage/build/reports/findbugs.html
-  - cat storage/build/reports/pmd.html
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest
     xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     package="com.firebase.uidemo">
 
     <uses-permission android:name="android.permission.INTERNET"/>
@@ -13,7 +14,8 @@
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:theme="@style/AppTheme"
-        android:supportsRtl="true">
+        android:supportsRtl="true"
+        tools:ignore="GoogleAppIndexingWarning">
         <activity android:name=".ChooserActivity">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN"/>
diff --git a/app/src/main/java/com/firebase/uidemo/database/ChatActivity.java b/app/src/main/java/com/firebase/uidemo/database/ChatActivity.java
@@ -46,6 +46,7 @@
 import com.google.firebase.database.FirebaseDatabase;
 import com.google.firebase.database.Query;
 
+@SuppressWarnings("LogConditional")
 public class ChatActivity extends AppCompatActivity implements FirebaseAuth.AuthStateListener {
     private static final String TAG = "RecyclerViewDemo";
 
diff --git a/app/src/main/java/com/firebase/uidemo/storage/ImageActivity.java b/app/src/main/java/com/firebase/uidemo/storage/ImageActivity.java
@@ -34,6 +34,7 @@
 import pub.devrel.easypermissions.AfterPermissionGranted;
 import pub.devrel.easypermissions.EasyPermissions;
 
+@SuppressWarnings("LogConditional")
 public class ImageActivity extends AppCompatActivity {
 
     private static final String TAG = "ImageDemo";
diff --git a/app/src/main/res/values-v21/styles.xml b/app/src/main/res/values-v21/styles.xml
@@ -63,11 +63,11 @@
         <item name="android:colorForeground">@color/material_gray_850</item>
         <item name="android:navigationBarColor">@android:color/black</item>
         <item name="android:statusBarColor">@android:color/black</item>
-        <item name="android:textColor">@color/abc_primary_text_material_dark</item>
-        <item name="android:textColorPrimary">@color/abc_primary_text_material_dark</item>
-        <item name="android:textColorPrimaryInverse">@color/abc_primary_text_material_light</item>
-        <item name="android:textColorSecondary">@color/abc_secondary_text_material_dark</item>
-        <item name="android:textColorSecondaryInverse">@color/abc_secondary_text_material_light</item>
+        <item name="android:textColor">@color/text_default_material_dark_primary</item>
+        <item name="android:textColorPrimary">@color/text_default_material_dark_primary</item>
+        <item name="android:textColorPrimaryInverse">@color/text_default_material_light_primary</item>
+        <item name="android:textColorSecondary">@color/text_default_material_dark_secondary</item>
+        <item name="android:textColorSecondaryInverse">@color/text_default_material_light_secondary</item>
         <item name="android:windowBackground">@color/material_gray_850</item>
     </style>
 
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
@@ -3,6 +3,12 @@
     <color name="colorPrimaryDark">#0288D1</color>
     <color name="colorAccent">#FFA000</color>
 
+    <!-- Text -->
+    <color name="text_default_material_dark_primary">#ffffffff</color>
+    <color name="text_default_material_light_primary">#de000000</color>
+    <color name="text_default_material_dark_secondary">#b3ffffff</color>
+    <color name="text_default_material_light_secondary">#8a000000</color>
+
     <color name="material_deep_purple_50">#EDE7F6</color>
     <color name="material_deep_purple_500">#673AB7</color>
     <color name="material_deep_purple_700">#512DA8</color>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
@@ -38,11 +38,11 @@
         <item name="colorAccent">@android:color/black</item>
         <item name="android:colorBackground">@color/material_gray_850</item>
         <item name="android:colorForeground">@android:color/white</item>
-        <item name="android:textColor">@color/abc_primary_text_material_dark</item>
-        <item name="android:textColorPrimary">@color/abc_primary_text_material_dark</item>
-        <item name="android:textColorPrimaryInverse">@color/abc_primary_text_material_light</item>
-        <item name="android:textColorSecondary">@color/abc_secondary_text_material_dark</item>
-        <item name="android:textColorSecondaryInverse">@color/abc_secondary_text_material_light</item>
+        <item name="android:textColor">@color/text_default_material_dark_primary</item>
+        <item name="android:textColorPrimary">@color/text_default_material_dark_primary</item>
+        <item name="android:textColorPrimaryInverse">@color/text_default_material_light_primary</item>
+        <item name="android:textColorSecondary">@color/text_default_material_dark_secondary</item>
+        <item name="android:textColorSecondaryInverse">@color/text_default_material_light_secondary</item>
         <item name="android:windowBackground">@color/material_gray_850</item>
     </style>
 
diff --git a/auth/src/main/AndroidManifest.xml b/auth/src/main/AndroidManifest.xml
@@ -33,6 +33,7 @@
 
         <activity
             android:name=".ui.email.RegisterEmailActivity"
+            android:label="@string/title_check_email"
             android:exported="false"
             android:theme="@style/FirebaseUI"/>
 
diff --git a/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java b/auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java
@@ -32,7 +32,8 @@
 
 /**
  * Activity to control the entire email sign up flow. Plays host to {@link CheckEmailFragment}
- * and {@link RegisterEmailFragment} and triggers {@link WelcomeBackPasswordPrompt}.
+ * and {@link RegisterEmailFragment} and triggers {@link WelcomeBackPasswordPrompt}
+ * and {@link WelcomeBackIdpPrompt}.
  */
 public class RegisterEmailActivity extends AppCompatBase implements
         CheckEmailFragment.CheckEmailListener {
diff --git a/auth/src/main/res/anim/slide_in_right.xml b/auth/src/main/res/anim/slide_in_right.xml
@@ -4,8 +4,4 @@
         android:duration="@android:integer/config_mediumAnimTime"
         android:fromXDelta="100%p"
         android:toXDelta="0%p" />
-    <!--<alpha-->
-        <!--android:duration="@android:integer/config_mediumAnimTime"-->
-        <!--android:fromAlpha="0.0"-->
-        <!--android:toAlpha="1.0" />-->
 </set>
diff --git a/auth/src/main/res/anim/slide_out_left.xml b/auth/src/main/res/anim/slide_out_left.xml
@@ -4,8 +4,4 @@
         android:duration="@android:integer/config_mediumAnimTime"
         android:fromXDelta="0%p"
         android:toXDelta="-100%p" />
-    <!--<alpha-->
-        <!--android:duration="@android:integer/config_mediumAnimTime"-->
-        <!--android:fromAlpha="1.0"-->
-        <!--android:toAlpha="0.0" />-->
 </set>
diff --git a/auth/src/main/res/layout/check_email_layout.xml b/auth/src/main/res/layout/check_email_layout.xml
@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools"
     style="@style/FirebaseUI.WrapperStyle"
     android:layout_width="match_parent"
     android:layout_height="wrap_content">
@@ -14,7 +15,8 @@
         android:transitionGroup="true"
         android:transitionName="email_field"
         app:errorTextAppearance="@style/FirebaseUI.Text.ErrorText"
-        app:hintTextAppearance="@style/FirebaseUI.Text.HintText">
+        app:hintTextAppearance="@style/FirebaseUI.Text.HintText"
+        tools:ignore="UnusedAttribute">
 
         <android.support.design.widget.TextInputEditText
             android:id="@+id/email"
diff --git a/auth/src/main/res/layout/register_email_layout.xml b/auth/src/main/res/layout/register_email_layout.xml
@@ -2,7 +2,8 @@
 <ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    xmlns:tools="http://schemas.android.com/tools">
 
     <RelativeLayout
         style="@style/FirebaseUI.WrapperStyle"
@@ -22,7 +23,8 @@
             android:transitionGroup="true"
             android:transitionName="email_field"
             app:errorTextAppearance="@style/FirebaseUI.Text.ErrorText"
-            app:hintTextAppearance="@style/FirebaseUI.Text.HintText">
+            app:hintTextAppearance="@style/FirebaseUI.Text.HintText"
+            tools:ignore="UnusedAttribute">
 
             <android.support.design.widget.TextInputEditText
                 android:id="@+id/email"
diff --git a/library/quality/lint-baseline.xml b/library/quality/lint-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<issues format="4" by="lint 2.3.0-alpha1">
+<issues format="4" by="lint 2.3.0-alpha2">
 
     <issue
         id="UnusedIds"
@@ -73,169 +73,6 @@
             column="5"/>
     </issue>
 
-    <issue
-        id="RtlEnabled"
-        message="The project references RTL attributes, but does not explicitly enable or disable RTL support with `android:supportsRtl` in the manifest">
-        <location
-            file="src\main\AndroidManifest.xml"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_primary_text_material_dark` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColor&quot;>@color/abc_primary_text_material_dark&lt;/item>
-"
-        errorLine2="                                       ^">
-        <location
-            file="src\main\res\values\styles.xml"
-            line="41"
-            column="40"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_primary_text_material_dark` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorPrimary&quot;>@color/abc_primary_text_material_dark&lt;/item>
-"
-        errorLine2="                                              ^">
-        <location
-            file="src\main\res\values\styles.xml"
-            line="42"
-            column="47"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_primary_text_material_light` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorPrimaryInverse&quot;>@color/abc_primary_text_material_light&lt;/item>
-"
-        errorLine2="                                                     ^">
-        <location
-            file="src\main\res\values\styles.xml"
-            line="43"
-            column="54"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_secondary_text_material_dark` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorSecondary&quot;>@color/abc_secondary_text_material_dark&lt;/item>
-"
-        errorLine2="                                                ^">
-        <location
-            file="src\main\res\values\styles.xml"
-            line="44"
-            column="49"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_secondary_text_material_light` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorSecondaryInverse&quot;>@color/abc_secondary_text_material_light&lt;/item>
-"
-        errorLine2="                                                       ^">
-        <location
-            file="src\main\res\values\styles.xml"
-            line="45"
-            column="56"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_primary_text_material_dark` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColor&quot;>@color/abc_primary_text_material_dark&lt;/item>
-"
-        errorLine2="                                       ^">
-        <location
-            file="src\main\res\values-v21\styles.xml"
-            line="66"
-            column="40"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_primary_text_material_dark` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorPrimary&quot;>@color/abc_primary_text_material_dark&lt;/item>
-"
-        errorLine2="                                              ^">
-        <location
-            file="src\main\res\values-v21\styles.xml"
-            line="67"
-            column="47"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_primary_text_material_light` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorPrimaryInverse&quot;>@color/abc_primary_text_material_light&lt;/item>
-"
-        errorLine2="                                                     ^">
-        <location
-            file="src\main\res\values-v21\styles.xml"
-            line="68"
-            column="54"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_secondary_text_material_dark` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorSecondary&quot;>@color/abc_secondary_text_material_dark&lt;/item>
-"
-        errorLine2="                                                ^">
-        <location
-            file="src\main\res\values-v21\styles.xml"
-            line="69"
-            column="49"/>
-    </issue>
-
-    <issue
-        id="PrivateResource"
-        message="The resource `@color/abc_secondary_text_material_light` is marked as private in com.android.support:appcompat-v7"
-        errorLine1="        &lt;item name=&quot;android:textColorSecondaryInverse&quot;>@color/abc_secondary_text_material_light&lt;/item>
-"
-        errorLine2="                                                       ^">
-        <location
-            file="src\main\res\values-v21\styles.xml"
-            line="70"
-            column="56"/>
-    </issue>
-
-    <issue
-        id="LogConditional"
-        message="The log call Log.d(...) should be conditional: surround with `if (Log.isLoggable(...))` or `if (BuildConfig.DEBUG) { ... }`"
-        errorLine1="                        Log.d(TAG, &quot;signInAnonymously:onComplete:&quot; + task.isSuccessful());
-"
-        errorLine2="                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src\main\java\com\firebase\uidemo\database\ChatActivity.java"
-            line="174"
-            column="25"/>
-    </issue>
-
-    <issue
-        id="LogConditional"
-        message="The log call Log.d(...) should be conditional: surround with `if (Log.isLoggable(...))` or `if (BuildConfig.DEBUG) { ... }`"
-        errorLine1="                        Log.d(TAG, &quot;signInAnonymously:&quot; + task.isSuccessful());
-"
-        errorLine2="                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
-        <location
-            file="src\main\java\com\firebase\uidemo\storage\ImageActivity.java"
-            line="67"
-            column="25"/>
-    </issue>
-
-    <issue
-        id="LogConditional"
-        message="The log call Log.d(...) should be conditional: surround with `if (Log.isLoggable(...))` or `if (BuildConfig.DEBUG) { ... }`"
-        errorLine1="                        Log.d(TAG, &quot;uploadPhoto:onSuccess:&quot; +
-"
-        errorLine2="                        ^">
-        <location
-            file="src\main\java\com\firebase\uidemo\storage\ImageActivity.java"
-            line="126"
-            column="25"/>
-    </issue>
-
     <issue
         id="UnusedResources"
         message="The resource `R.string.google_crash_reporting_api_key` appears to be unused"
@@ -251,16 +88,4 @@
             column="13"/>
     </issue>
 
-    <issue
-        id="GoogleAppIndexingWarning"
-        message="App is not indexable by Google Search; consider adding at least one Activity with an ACTION-VIEW intent filter. See issue explanation for more details."
-        errorLine1="    &lt;application
-"
-        errorLine2="    ^">
-        <location
-            file="src\main\AndroidManifest.xml"
-            line="9"
-            column="5"/>
-    </issue>
-
 </issues>
