Skip to content

Commit 276f677

Browse files
committed
Make build pass
Change-Id: Ic3851f7e43a44447c65ff7ea9f721a5a0eda88af
1 parent eddcbed commit 276f677

File tree

3 files changed

+12
-8
lines changed

3 files changed

+12
-8
lines changed

firestore/src/main/java/com/firebase/ui/firestore/paging/FirestoreDataSource.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public FirestoreDataSource(Query baseQuery) {
5151
@Override
5252
public void loadInitial(@NonNull LoadInitialParams<PageKey> params,
5353
@NonNull final LoadInitialCallback<PageKey, DocumentSnapshot> callback) {
54-
Log.d(TAG, "loadInitial: " + params.requestedLoadSize);
54+
logd("loadInitial: " + params.requestedLoadSize);
5555

5656
// Set initial loading state
5757
mLoadingState.postValue(LoadingState.LOADING_INITIAL);
@@ -101,7 +101,7 @@ public void loadBefore(@NonNull LoadParams<PageKey> params,
101101
public void loadAfter(@NonNull LoadParams<PageKey> params,
102102
@NonNull final LoadCallback<PageKey, DocumentSnapshot> callback) {
103103
final PageKey key = params.key;
104-
Log.d(TAG, "loadAfter: " + key + ", " + params.requestedLoadSize);
104+
logd("loadAfter: " + key + ", " + params.requestedLoadSize);
105105

106106
// Set loading state
107107
mLoadingState.postValue(LoadingState.LOADING_MORE);
@@ -147,4 +147,10 @@ private DocumentSnapshot getLast(List<DocumentSnapshot> data) {
147147
return data.get(data.size() - 1);
148148
}
149149
}
150+
151+
private static void logd(String message) {
152+
if (Log.isLoggable(TAG, Log.DEBUG)) {
153+
Log.d(TAG, message);
154+
}
155+
}
150156
}

firestore/src/main/java/com/firebase/ui/firestore/paging/FirestorePagingOptions.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.firebase.ui.firestore.paging;
22

33
import android.arch.lifecycle.LifecycleOwner;
4+
import android.arch.paging.LivePagedListBuilder;
45
import android.arch.paging.PagedList;
56
import android.support.annotation.NonNull;
67
import android.support.annotation.Nullable;
@@ -62,7 +63,7 @@ public Builder<T> setQuery(@NonNull Query query,
6263

6364
// Build paged list
6465
FirestoreDataSource.Factory factory = new FirestoreDataSource.Factory(query);
65-
mData = new PagingData(factory, config);
66+
mData = new PagingData(new LivePagedListBuilder<>(factory, config).build());
6667

6768
mParser = parser;
6869
return this;

firestore/src/main/java/com/firebase/ui/firestore/paging/PagingData.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import android.arch.core.util.Function;
44
import android.arch.lifecycle.LiveData;
55
import android.arch.lifecycle.Transformations;
6-
import android.arch.paging.LivePagedListBuilder;
76
import android.arch.paging.PagedList;
87
import android.support.annotation.NonNull;
98
import android.support.annotation.RestrictTo;
@@ -19,10 +18,8 @@ public class PagingData {
1918
private final LiveData<PagedList<DocumentSnapshot>> mSnapshots;
2019
private final LiveData<LoadingState> mLoadingState;
2120

22-
public PagingData(@NonNull FirestoreDataSource.Factory factory,
23-
@NonNull PagedList.Config config) {
24-
25-
mSnapshots = new LivePagedListBuilder<>(factory, config).build();
21+
public PagingData(@NonNull LiveData<PagedList<DocumentSnapshot>> snapshots) {
22+
mSnapshots = snapshots;
2623

2724
mLoadingState = Transformations.switchMap(mSnapshots,
2825
new Function<PagedList<DocumentSnapshot>, LiveData<LoadingState>>() {

0 commit comments

Comments
 (0)