Skip to content

Commit 280ad5c

Browse files
SUPERCILEXsamtstern
authored andcommitted
Fix email -> Google smart lock credential not being deleted when user selects it (#837)
1 parent 340035c commit 280ad5c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

auth/src/main/java/com/firebase/ui/auth/util/signincontainer/SignInDelegate.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@
1616
import com.firebase.ui.auth.IdpResponse;
1717
import com.firebase.ui.auth.R;
1818
import com.firebase.ui.auth.ResultCodes;
19+
import com.firebase.ui.auth.User;
1920
import com.firebase.ui.auth.ui.ExtraConstants;
2021
import com.firebase.ui.auth.ui.FlowParameters;
2122
import com.firebase.ui.auth.ui.TaskFailureLogger;
22-
import com.firebase.ui.auth.User;
2323
import com.firebase.ui.auth.ui.email.RegisterEmailActivity;
2424
import com.firebase.ui.auth.ui.idp.AuthMethodPickerActivity;
2525
import com.firebase.ui.auth.ui.phone.PhoneVerificationActivity;
@@ -40,6 +40,7 @@
4040
import com.google.firebase.auth.AuthResult;
4141
import com.google.firebase.auth.EmailAuthProvider;
4242
import com.google.firebase.auth.FacebookAuthProvider;
43+
import com.google.firebase.auth.FirebaseAuthInvalidCredentialsException;
4344
import com.google.firebase.auth.FirebaseAuthInvalidUserException;
4445
import com.google.firebase.auth.GoogleAuthProvider;
4546
import com.google.firebase.auth.PhoneAuthProvider;
@@ -289,7 +290,8 @@ public void onSuccess(AuthResult authResult) {
289290
.addOnFailureListener(new OnFailureListener() {
290291
@Override
291292
public void onFailure(@NonNull Exception e) {
292-
if (e instanceof FirebaseAuthInvalidUserException) {
293+
if (e instanceof FirebaseAuthInvalidUserException
294+
|| e instanceof FirebaseAuthInvalidCredentialsException) {
293295
// In this case the credential saved in SmartLock was not
294296
// a valid credential, we should delete it from SmartLock
295297
// before continuing.

0 commit comments

Comments
 (0)