Make lint pass

Change-Id: I2264ada2d13cf9c667680f3a278f7b5e2edf0cb0

Author: samtstern

app/src/main/res/layout/activity_firestore_paging.xml

@@ -12,7 +12,8 @@
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginTop="-6dp"
-        android:background="@android:color/transparent" />
+        android:background="@android:color/transparent"
+        tools:ignore="NegativeMargin" />
 
     <android.support.v7.widget.RecyclerView
         android:id="@+id/paging_recycler"

app/src/main/res/layout/item_item.xml

@@ -4,18 +4,19 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
+    android:layout_marginBottom="8dp"
     android:paddingLeft="16dp"
     android:paddingRight="16dp"
-    android:paddingBottom="8dp"
     android:paddingTop="8dp"
-    android:layout_marginBottom="8dp"
+    android:paddingBottom="8dp"
     android:background="@drawable/ic_chat_message_background"
     android:orientation="vertical">
 
     <TextView
         android:id="@+id/item_text"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
+        android:textIsSelectable="false"
         android:textSize="16sp"
         android:textStyle="bold"
         tools:text="My Text" />
@@ -24,6 +25,7 @@
         android:id="@+id/item_value"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
+        android:textIsSelectable="false"
         android:textSize="12sp"
         tools:text="1234" />
 

firestore/src/main/java/com/firebase/ui/firestore/FirestorePagingAdapter.java

@@ -80,7 +80,7 @@ public void loadPrevPage() {
         int lastUnloadedBefore = findLastOfState(PageState.UNLOADED, firstLoaded);
 
         if (lastUnloadedBefore != -1) {
-            Log.d(TAG, "RELOADING " + lastUnloadedBefore);
+            logd("RELOADING " + lastUnloadedBefore);
 
             Page page = mPages.get(lastUnloadedBefore);
             DocumentSnapshot endBefore = getFirstOfPage(lastUnloadedBefore + 1);
@@ -122,15 +122,15 @@ public void loadNextPage() {
             Page nextPage = new Page(nextPageIndex);
             mPages.add(nextPage);
 
-            Log.d(TAG, "LOADING " + nextPageIndex);
+            logd("LOADING " + nextPageIndex);
             Query nextQuery = queryAfter(lastSnapshot);
             nextPage.load(nextQuery);
         } else {
             // Case 2: Need to load a previously unloaded page
             // Find the first UNLOADED page after the middle "core" of loaded pages
             int firstUnloadedAfter = findFirstOfState(PageState.UNLOADED, lastLoaded);
 
-            Log.d(TAG, "RELOADING " + firstUnloadedAfter);
+            logd("RELOADING " + firstUnloadedAfter);
             Page page = mPages.get(firstUnloadedAfter);
             DocumentSnapshot endBefore = getFirstOfPage(firstUnloadedAfter + 1);
             Query query = queryBetween(page.getFirst(), endBefore);
@@ -185,15 +185,15 @@ private void unloadTopPage() {
         int firstLoaded = findFirstOfState(PageState.LOADED);
         if (firstLoaded != -1) {
             mPages.get(firstLoaded).unload();
-            Log.d(TAG, "UNLOADING " + firstLoaded);
+            logd("UNLOADING " + firstLoaded);
         }
     }
 
     private void unloadBottomPage() {
         int lastLoaded = findLastOfState(PageState.LOADED);
         if (lastLoaded != -1) {
             mPages.get(lastLoaded).unload();
-            Log.d(TAG, "UNLOADING " + lastLoaded);
+            logd("UNLOADING " + lastLoaded);
         }
     }
 
@@ -304,6 +304,12 @@ private Query queryAfter(@Nullable DocumentSnapshot startAfter) {
         return query;
     }
 
+    private void logd(String message) {
+        if (Log.isLoggable(TAG, Log.DEBUG)) {
+            Log.d(TAG, message);
+        }
+    }
+
     private enum PageState {
         LOADING,
         LOADED,
@@ -359,7 +365,7 @@ public void onComplete(@NonNull Task<QuerySnapshot> task) {
             }
 
             // Mark page as loaded
-            Log.d(TAG, "LOADED " + mIndex);
+            logd("LOADED " + mIndex);
             mState = PageState.LOADED;
             onPageLoaded(mIndex, mSnapshots.size());
         }