Skip to content

Commit 2fb28a1

Browse files
SUPERCILEXsamtstern
SUPERCILEX
authored and
samtstern
committed
Fix overlapping view and padding issues (#1324)
1 parent d460977 commit 2fb28a1

9 files changed

+54
-59
lines changed

‎auth/src/main/res/layout-land/fui_auth_method_picker_layout.xml

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,26 @@
2121
app:layout_constraintStart_toStartOf="parent"
2222
app:layout_constraintEnd_toStartOf="@+id/container"
2323
app:layout_constraintTop_toTopOf="parent"
24-
app:layout_constraintBottom_toBottomOf="parent"
24+
app:layout_constraintBottom_toTopOf="@+id/main_tos_and_pp"
2525
tools:ignore="ContentDescription" /> <!-- TODO remove once the bug is fixed: https://issuetracker.google.com/issues/38281866-->
2626

27+
<TextView
28+
android:id="@+id/main_tos_and_pp"
29+
style="@style/FirebaseUI.Text.BodyText"
30+
android:layout_width="0dp"
31+
android:layout_height="0dp"
32+
android:layout_marginLeft="@dimen/fui_wrapper_padding_horiz"
33+
android:layout_marginRight="@dimen/fui_wrapper_padding_horiz"
34+
android:layout_marginTop="@dimen/fui_field_padding_vert"
35+
android:layout_marginBottom="@dimen/fui_field_padding_vert"
36+
android:gravity="center"
37+
android:textColor="?android:attr/textColorTertiary"
38+
android:textIsSelectable="false"
39+
app:layout_constraintStart_toStartOf="parent"
40+
app:layout_constraintEnd_toStartOf="@+id/container"
41+
app:layout_constraintTop_toBottomOf="@+id/logo"
42+
app:layout_constraintBottom_toBottomOf="parent" />
43+
2744
<ScrollView
2845
android:id="@+id/container"
2946
android:layout_width="wrap_content"
@@ -40,20 +57,4 @@
4057

4158
</ScrollView>
4259

43-
<TextView
44-
android:id="@+id/main_tos_and_pp"
45-
style="@style/FirebaseUI.Text.BodyText"
46-
android:layout_width="0dp"
47-
android:layout_height="wrap_content"
48-
android:layout_marginLeft="32dp"
49-
android:layout_marginRight="32dp"
50-
android:layout_marginTop="@dimen/fui_field_padding_vert"
51-
android:layout_marginBottom="@dimen/fui_field_padding_vert"
52-
android:gravity="center"
53-
android:textColor="?android:attr/textColorTertiary"
54-
android:textIsSelectable="true"
55-
app:layout_constraintLeft_toLeftOf="parent"
56-
app:layout_constraintRight_toLeftOf="@+id/container"
57-
app:layout_constraintBottom_toBottomOf="parent" />
58-
5960
</android.support.constraint.ConstraintLayout>

‎auth/src/main/res/layout/fui_activity_register_email.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,4 @@
55
android:id="@+id/fragment_register_email"
66
android:layout_width="match_parent"
77
android:layout_height="match_parent"
8-
tools:ignore="MergeRootFrame">
9-
</FrameLayout>
10-
8+
tools:ignore="MergeRootFrame" />

‎auth/src/main/res/layout/fui_activity_register_phone.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,4 @@
55
android:id="@+id/fragment_phone"
66
android:layout_width="match_parent"
77
android:layout_height="match_parent"
8-
tools:ignore="MergeRootFrame">
9-
</FrameLayout>
10-
8+
tools:ignore="MergeRootFrame" />

‎auth/src/main/res/layout/fui_auth_method_picker_layout.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
android:id="@+id/root"
77
android:layout_width="match_parent"
88
android:layout_height="match_parent"
9-
android:clipChildren="false"
109
android:clipToPadding="false">
1110

1211
<me.zhanghai.android.materialprogressbar.MaterialProgressBar
@@ -29,10 +28,10 @@
2928
<ScrollView
3029
android:id="@+id/container"
3130
android:layout_width="wrap_content"
32-
android:layout_height="wrap_content"
31+
android:layout_height="0dp"
3332
app:layout_constraintStart_toStartOf="parent"
3433
app:layout_constraintEnd_toEndOf="parent"
35-
app:layout_constraintTop_toTopOf="parent"
34+
app:layout_constraintTop_toBottomOf="@+id/logo"
3635
app:layout_constraintBottom_toTopOf="@+id/main_tos_and_pp"
3736
app:layout_constraintVertical_bias="0.7">
3837

@@ -52,6 +51,7 @@
5251
android:gravity="center"
5352
android:textColor="?android:textColorTertiary"
5453
android:textIsSelectable="true"
54+
app:layout_constraintTop_toBottomOf="@+id/container"
5555
app:layout_constraintBottom_toBottomOf="parent" />
5656

5757
</android.support.constraint.ConstraintLayout>

‎auth/src/main/res/layout/fui_check_email_layout.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@
1414

1515
<ScrollView
1616
android:layout_width="match_parent"
17-
android:layout_height="match_parent"
18-
tools:ignore="UselessParent">
17+
android:layout_height="match_parent">
1918

2019
<LinearLayout
2120
style="@style/FirebaseUI.WrapperStyle"

‎auth/src/main/res/layout/fui_phone_layout.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,11 +61,11 @@
6161
<TextView
6262
android:id="@+id/email_footer_tos_and_pp_text"
6363
style="@style/FirebaseUI.PrivacyFooter"
64-
app:layout_constraintTop_toBottomOf="@+id/send_sms_tos" />
64+
app:layout_constraintTop_toBottomOf="@+id/send_sms_tos"
65+
app:layout_constraintBottom_toBottomOf="parent" />
6566

6667
</android.support.constraint.ConstraintLayout>
6768

6869
</ScrollView>
6970

7071
</android.support.constraint.ConstraintLayout>
71-

‎auth/src/main/res/layout/fui_register_email_layout.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@
1515
<ScrollView
1616
android:layout_width="match_parent"
1717
android:layout_height="match_parent"
18-
android:layout_marginTop="8dp"
19-
android:paddingBottom="16dp"
20-
android:clipToPadding="false"
21-
tools:ignore="UselessParent">
18+
android:clipToPadding="false">
2219

2320
<LinearLayout
2421
style="@style/FirebaseUI.WrapperStyle"

‎auth/src/main/res/layout/fui_welcome_back_idp_prompt_layout.xml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<ScrollView xmlns:android="http://schemas.android.com/apk/res/android"
2+
<LinearLayout
3+
xmlns:android="http://schemas.android.com/apk/res/android"
34
xmlns:tools="http://schemas.android.com/tools"
45
android:layout_width="match_parent"
5-
android:layout_height="match_parent">
6+
android:layout_height="match_parent"
7+
android:orientation="vertical">
68

7-
<LinearLayout
8-
android:layout_width="match_parent"
9-
android:layout_height="wrap_content"
10-
android:orientation="vertical">
9+
<me.zhanghai.android.materialprogressbar.MaterialProgressBar
10+
android:id="@+id/top_progress_bar"
11+
style="@style/FirebaseUI.TopProgressBar"
12+
tools:visibility="visible" />
1113

12-
<me.zhanghai.android.materialprogressbar.MaterialProgressBar
13-
android:id="@+id/top_progress_bar"
14-
style="@style/FirebaseUI.TopProgressBar"
15-
tools:visibility="visible" />
14+
<ScrollView
15+
android:layout_width="match_parent"
16+
android:layout_height="match_parent">
1617

1718
<LinearLayout
1819
style="@style/FirebaseUI.WrapperStyle"
@@ -44,6 +45,6 @@
4445

4546
</LinearLayout>
4647

47-
</LinearLayout>
48+
</ScrollView>
4849

49-
</ScrollView>
50+
</LinearLayout>

‎auth/src/main/res/layout/fui_welcome_back_password_prompt_layout.xml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<ScrollView
2+
<LinearLayout
33
xmlns:android="http://schemas.android.com/apk/res/android"
44
xmlns:app="http://schemas.android.com/apk/res-auto"
55
xmlns:tools="http://schemas.android.com/tools"
66
android:layout_width="match_parent"
7-
android:layout_height="match_parent">
7+
android:layout_height="match_parent"
8+
android:orientation="vertical">
89

9-
<LinearLayout
10-
android:layout_width="match_parent"
11-
android:layout_height="wrap_content"
12-
android:orientation="vertical">
10+
<me.zhanghai.android.materialprogressbar.MaterialProgressBar
11+
android:id="@+id/top_progress_bar"
12+
style="@style/FirebaseUI.TopProgressBar"
13+
tools:visibility="visible" />
1314

14-
<me.zhanghai.android.materialprogressbar.MaterialProgressBar
15-
android:id="@+id/top_progress_bar"
16-
style="@style/FirebaseUI.TopProgressBar"
17-
tools:visibility="visible" />
15+
<ScrollView
16+
android:layout_width="match_parent"
17+
android:layout_height="match_parent">
1818

1919
<android.support.constraint.ConstraintLayout
2020
style="@style/FirebaseUI.WrapperStyle"
@@ -74,10 +74,11 @@
7474
<TextView
7575
android:id="@+id/email_footer_tos_and_pp_text"
7676
style="@style/FirebaseUI.PrivacyFooter"
77-
app:layout_constraintTop_toBottomOf="@+id/button_done" />
77+
app:layout_constraintTop_toBottomOf="@+id/button_done"
78+
app:layout_constraintBottom_toBottomOf="parent" />
7879

7980
</android.support.constraint.ConstraintLayout>
8081

81-
</LinearLayout>
82+
</ScrollView>
8283

83-
</ScrollView>
84+
</LinearLayout>

0 commit comments

Comments
 (0)