Skip to content

Commit 35cede6

Browse files
committed
Address review feedback
Signed-off-by: Alex Saveau <[email protected]>
1 parent 03d0d64 commit 35cede6

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,10 +171,15 @@ protected void onFailure(@NonNull Exception e) {
171171
}
172172

173173
private void handleResponse(@NonNull IdpResponse response) {
174-
if (!response.isSuccessful()
175-
|| AuthUI.SOCIAL_PROVIDERS.contains(response.getProviderType())) {
174+
if (!response.isSuccessful()) {
175+
// We have no idea what provider this error stemmed from so just forward
176+
// this along to the handler.
177+
handler.startSignIn(response);
178+
} else if (AuthUI.SOCIAL_PROVIDERS.contains(response.getProviderType())) {
176179
handler.startSignIn(response);
177180
} else {
181+
// Email or phone: the credentials should have already been saved so simply
182+
// move along.
178183
finish(response.isSuccessful() ? RESULT_OK : RESULT_CANCELED,
179184
response.toIntent());
180185
}

0 commit comments

Comments
 (0)