Skip to content

Commit 4467473

Browse files
committed
Made Facebook, Google and Email buttons have their text as their corresponding sign_in_with_* resource string.
1 parent 78e3c6d commit 4467473

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

auth/src/main/res/layout/auth_method_picker_layout.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
<Button
2626
android:id="@+id/email_provider"
2727
style="@style/FirebaseUI.Button.AccountChooser.EmailButton"
28-
android:text="@string/email_button_text"/>
28+
android:text="@string/sign_in_with_email"/>
2929

3030
</LinearLayout>
3131

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Button
22
xmlns:android="http://schemas.android.com/apk/res/android"
33
style="@style/FirebaseUI.Button.AccountChooser.FacebookButton"
4-
android:text="Sign in with Facebook"
4+
android:text="@string/sign_in_with_facebook"
55
android:id="@+id/facebook_button"
66
/>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<Button
22
xmlns:android="http://schemas.android.com/apk/res/android"
33
style="@style/FirebaseUI.Button.AccountChooser.GoogleButton"
4-
android:text="Sign in with Google"
4+
android:text="@string/sign_in_with_google"
55
android:id="@+id/google_button"
66
/>

auth/src/main/res/values/strings.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
2-
<string name="email_button_text">Sign in with email</string>
32
<string name="app_name">ui_flow</string>
43
<string name="email_hint">Email</string>
54
<string name="sign_in_no_password_title">Put an email to use for sign in</string>

0 commit comments

Comments
 (0)