Skip to content

Commit 4653e31

Browse files
Remove BaselineTextView (#1672)
Co-Authored-By: Rosário Pereira Fernandes <[email protected]>
1 parent 942663f commit 4653e31

File tree

6 files changed

+9
-39
lines changed

6 files changed

+9
-39
lines changed

auth/src/main/java/com/firebase/ui/auth/ui/email/EmailLinkCatcherActivity.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ public void onClick(DialogInterface dialog, int id) {
128128

129129
@Override
130130
public void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
131+
super.onActivityResult(requestCode, resultCode, data);
131132
if (requestCode == RequestCodes.EMAIL_LINK_PROMPT_FOR_EMAIL_FLOW
132133
|| requestCode == RequestCodes.EMAIL_LINK_CROSS_DEVICE_LINKING_FLOW) {
133134
IdpResponse response = IdpResponse.fromResultIntent(data);

auth/src/main/java/com/firebase/ui/auth/ui/email/EmailLinkCrossDeviceLinkingFragment.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.firebase.ui.auth.ui.email;
22

3+
import android.annotation.SuppressLint;
34
import android.os.Build;
45
import android.os.Bundle;
56
import android.text.SpannableStringBuilder;
@@ -22,8 +23,6 @@
2223
import androidx.annotation.RestrictTo;
2324
import androidx.fragment.app.FragmentActivity;
2425

25-
import static android.text.Layout.JUSTIFICATION_MODE_INTER_WORD;
26-
2726
/**
2827
* Fragment that tells the user that a linking flow cannot be completed as they have opened the
2928
* email link on a different device.
@@ -52,6 +51,7 @@ public View onCreateView(@NonNull LayoutInflater inflater,
5251

5352
@SuppressWarnings("WrongConstant")
5453
@Override
54+
@SuppressLint("WrongConstant")
5555
public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
5656
mProgressBar = view.findViewById(R.id.top_progress_bar);
5757
mContinueButton = view.findViewById(R.id.button_continue);
@@ -73,7 +73,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
7373

7474
// Justifies the text
7575
if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
76-
body.setJustificationMode(JUSTIFICATION_MODE_INTER_WORD);
76+
body.setJustificationMode(android.text.Layout.JUSTIFICATION_MODE_INTER_WORD);
7777
}
7878

7979
TextView footerText = view.findViewById(R.id.email_footer_tos_and_pp_text);

auth/src/main/java/com/firebase/ui/auth/ui/email/WelcomeBackEmailLinkPrompt.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.firebase.ui.auth.ui.email;
22

3+
import android.annotation.SuppressLint;
34
import android.content.Context;
45
import android.content.Intent;
56
import android.os.Build;
@@ -22,8 +23,6 @@
2223
import androidx.annotation.Nullable;
2324
import androidx.annotation.RestrictTo;
2425

25-
import static android.text.Layout.JUSTIFICATION_MODE_INTER_WORD;
26-
2726
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
2827
public class WelcomeBackEmailLinkPrompt extends AppCompatBase implements View.OnClickListener {
2928

@@ -85,7 +84,7 @@ private void setBodyText() {
8584
body.setText(spannableStringBuilder);
8685
// Justifies the text
8786
if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
88-
body.setJustificationMode(JUSTIFICATION_MODE_INTER_WORD);
87+
body.setJustificationMode(android.text.Layout.JUSTIFICATION_MODE_INTER_WORD);
8988
}
9089
}
9190

auth/src/main/java/com/firebase/ui/auth/util/ui/BaselineTextInputLayout.java

Lines changed: 0 additions & 30 deletions
This file was deleted.

auth/src/main/res/layout/fui_phone_layout.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
app:layout_constraintStart_toStartOf="parent"
2828
app:layout_constraintBaseline_toBaselineOf="@+id/phone_layout" />
2929

30-
<com.firebase.ui.auth.util.ui.BaselineTextInputLayout
30+
<com.google.android.material.textfield.TextInputLayout
3131
android:id="@+id/phone_layout"
3232
style="@style/FirebaseUI.TextInputLayout.PhoneField"
3333
android:layout_width="0dp"
@@ -41,7 +41,7 @@
4141
style="@style/FirebaseUI.TextInputEditText.PhoneField"
4242
android:imeOptions="actionDone" />
4343

44-
</com.firebase.ui.auth.util.ui.BaselineTextInputLayout>
44+
</com.google.android.material.textfield.TextInputLayout>
4545

4646
<Button
4747
android:id="@+id/send_code"

buildSrc/src/main/kotlin/Config.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ object Config {
3939
const val paging = "androidx.paging:paging-runtime:2.1.0"
4040
const val recyclerView = "androidx.recyclerview:recyclerview:1.0.0"
4141

42-
const val design = "com.google.android.material:material:1.0.0"
42+
const val design = "com.google.android.material:material:1.1.0"
4343
}
4444

4545
object Firebase {

0 commit comments

Comments
 (0)