Fixed a bug and added another test that verifies it.

Author: CodingDoug

database/src/androidTest/java/com/firebase/ui/database/FirebaseArrayTest.java

@@ -112,7 +112,7 @@ public Boolean call() throws Exception {
     }
 
     @Test
-    public void testChangePriorities() throws Exception {
+    public void testChangePriorityBackToFront() throws Exception {
         runAndWaitUntil(mArray, new Runnable() {
             public void run() {
                 mArray.getItem(2).getRef().setPriority(0.5);
@@ -123,4 +123,17 @@ public Boolean call() throws Exception {
             }
         });
     }
+
+    @Test
+    public void testChangePriorityFrontToBack() throws Exception {
+        runAndWaitUntil(mArray, new Runnable() {
+            public void run() {
+                mArray.getItem(0).getRef().setPriority(4);
+            }
+        }, new Callable<Boolean>() {
+            public Boolean call() throws Exception {
+                return isValuesEqual(mArray, new int[]{2, 3, 1});
+            }
+        });
+    }
 }

database/src/main/java/com/firebase/ui/database/FirebaseArray.java

@@ -120,17 +120,17 @@ public void setOnChangedListener(OnChangedListener listener) {
         mListener = listener;
     }
 
-    protected void notifyChangedListeners(OnChangedListener.EventType type, int index) {
+    void notifyChangedListeners(OnChangedListener.EventType type, int index) {
         notifyChangedListeners(type, index, -1);
     }
 
-    protected void notifyChangedListeners(OnChangedListener.EventType type, int index, int oldIndex) {
+    void notifyChangedListeners(OnChangedListener.EventType type, int index, int oldIndex) {
         if (mListener != null) {
             mListener.onChildChanged(type, index, oldIndex);
         }
     }
 
-    protected void notifyCancelledListeners(DatabaseError databaseError) {
+    void notifyCancelledListeners(DatabaseError databaseError) {
         if (mListener != null) {
             mListener.onCancelled(databaseError);
         }