Skip to content

Commit 5400d9d

Browse files
committed
fixes
1 parent 9f7a46f commit 5400d9d

File tree

3 files changed

+19
-18
lines changed

3 files changed

+19
-18
lines changed

.github/workflows/android.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/checkout@v2
12-
- name: set up JDK 11
12+
- name: set up JDK 17
1313
uses: actions/setup-java@v1
1414
with:
1515
java-version: 17

auth/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,6 @@ dependencies {
7777
implementation(Config.Libs.Androidx.customTabs)
7878
implementation(Config.Libs.Androidx.constraint)
7979
implementation("androidx.credentials:credentials:1.3.0")
80-
implementation("androidx.core:core-ktx:1.10.1")
8180

8281
implementation(Config.Libs.Androidx.lifecycleExtensions)
8382
implementation("androidx.core:core-ktx:1.13.1")

auth/src/main/java/com/firebase/ui/auth/ui/credentials/CredentialSaveActivity.kt

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,7 @@ import com.google.firebase.auth.FirebaseAuth
1717

1818
class CredentialSaveActivity : InvisibleActivityBase() {
1919

20-
companion object {
21-
private const val TAG = "CredentialSaveActivity"
22-
23-
@JvmStatic
24-
fun createIntent(
25-
context: Context,
26-
flowParams: FlowParameters,
27-
credential: Credential,
28-
response: IdpResponse
29-
): Intent {
30-
return createBaseIntent(context, CredentialSaveActivity::class.java, flowParams).apply {
31-
putExtra(ExtraConstants.CREDENTIAL, credential)
32-
putExtra(ExtraConstants.IDP_RESPONSE, response)
33-
}
34-
}
35-
}
20+
3621

3722
private lateinit var credentialManagerHandler: CredentialManagerHandler
3823

@@ -86,4 +71,21 @@ class CredentialSaveActivity : InvisibleActivityBase() {
8671
Log.d(TAG, "Save operation in progress, doing nothing.")
8772
}
8873
}
74+
75+
companion object {
76+
private const val TAG = "CredentialSaveActivity"
77+
78+
@JvmStatic
79+
fun createIntent(
80+
context: Context,
81+
flowParams: FlowParameters,
82+
credential: Credential,
83+
response: IdpResponse
84+
): Intent {
85+
return createBaseIntent(context, CredentialSaveActivity::class.java, flowParams).apply {
86+
putExtra(ExtraConstants.CREDENTIAL, credential)
87+
putExtra(ExtraConstants.IDP_RESPONSE, response)
88+
}
89+
}
90+
}
8991
}

0 commit comments

Comments
 (0)